Fleet #935
Merged
Fleet #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we execute it from VimStateMachine directly, then mode change listeners are not notified
It is global in Vim
This bug was caused by two reasons: 1. KeyHandler state is not longer per-editor and we can't reset it on editor creation 2. We do not need to do such things on editor creation. What actually matters is focusing the editor
Mode is global now
…l in Fleet Why is the old interface bad? - it is not obvious. You cannot create a new panel or check if it is already created. Only "getOrCreate" it - output panel is bound to editor while in Vim it is global - we have the `isActive` field and the `clear()` method at the same time, because interface implies that you store the same instance of the panel and reactivate it for each output and I don't like it. We also can forget to call `clear()` after reusing panel - we cannot "build" output before showing to make the panel more efficient. With multiple carets we can only cal `output(oldText + newText)` for each caret, and it is bad. (imagine we have global command with a lot of matches and for each time we will need to call the `output(oldText + newText)`) - the `output()` method shows panel, activates it and updates it - there are more things that I do not like, but the points above should be already enough
It's an oneliner that we can live without
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.