Handle cancellation while waiting for an encrypted IP response #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fixes the IP controller. BLE and coap likely have similar issues home-assistant/core#97888
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 74.50% 74.60% +0.09%
==========================================
Files 99 99
Lines 9301 9320 +19
==========================================
+ Hits 6930 6953 +23
+ Misses 2371 2367 -4 ☔ View full report in Codecov by Sentry. |
bdraco
commented
Jan 13, 2024
Comment on lines
+118
to
+121
| # If we get a timeout or any other exception then we need to | ||
| # close the connection as we are now out of sync with the device | ||
| # and any future requests will fail since the encryption counters | ||
| # will be out of sync. |
There was a problem hiding this comment.
We might be able to redo the pair verify and start over but I doubt devices handle that well so I think the safest thing to do is close and reopen to ensure good state
Jc2k
approved these changes
Jan 13, 2024
|
thanks. will push a release shortly if everything passes on 3.12 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fixes the IP controller. BLE and coap likely have similar issues. I will fix BLE as well but I don't use coap so no way to test that one
home-assistant/core#97888