Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cancellation while waiting for an encrypted BLE response #356

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

bdraco
Copy link
Collaborator

@bdraco bdraco commented Jan 13, 2024

same as #354 for BLE

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f25dcb1) 74.50% compared to head (35987f7) 74.45%.

Files Patch % Lines
aiohomekit/controller/ble/pairing.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   74.50%   74.45%   -0.06%     
==========================================
  Files          99       99              
  Lines        9301     9308       +7     
==========================================
  Hits         6930     6930              
- Misses       2371     2378       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review January 13, 2024 07:13
@bdraco
Copy link
Collaborator Author

bdraco commented Jan 13, 2024

flakey 3.10 windows test failure is unrelated

@bdraco bdraco merged commit 6e8e374 into main Jan 13, 2024
8 of 12 checks passed
@bdraco bdraco deleted the ble_cancel branch January 13, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants