-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update burst compute workflow to prepare it for node18 backend #1
Open
cgoina
wants to merge
25
commits into
master
Choose a base branch
from
node18
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
509cec2
a first take to use node18 but invoke async does not work
f49de7e
use map to distribute the work
82e7ed3
filter parameters to not pass batch results around
eda5a29
eliminated filter params state
eaa18b0
added persist results state in order to persist directly from the sta…
451189e
removed states that did not seem to be used and from map went directl…
64c6e42
added states to handle partitioning of the batch jobs in order to sat…
a1d0ad4
specify payload for combine function to exclude batches
9e35153
put monitor back to check for timeout
0367b23
monitor needs all parameters that must propagate such as firstBatchId…
9603af6
use dump batches on s3 and use itemreader
79c7665
introduce an intermediate state to set completed flag
8d8325d
specify runtime and architecture in the provider block - switch to arm64
f22c50a
Merge branch 'master' into node18
32538bd
update some packages
f51e981
set up an org and updated the bundle plugin
8dd61b0
update runtime to node20x
b61d61a
set toleratedPercentageFailure
70674df
added cleanup step - to clean batch inputs
932d865
changed logging message
038934e
dotenv; additional state to check for errors
1ed9091
renamed branching factor
b8498e4
updated the to describe the new workflow
d506298
update the default interface name
55578e3
updated diagram
krokicki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
MAX_PARALLELISM=5000 | ||
MAX_BATCHED_JOBS_ITERATIONS=2 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point both values are the same as the defaults so it could be removed - I used this to test it with multiple values to find the best settings.