Update burst compute workflow to prepare it for node18 backend #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
November 10, 2023 08:58
…y to combine or combineerror
…isfy the input size constraint of 256K
…, lastBatchId, datasetStartIndex and datasetEndIndex
cgoina
commented
Feb 26, 2025
| @@ -0,0 +1,2 @@ | |||
| MAX_PARALLELISM=5000 | |||
| MAX_BATCHED_JOBS_ITERATIONS=2 | |||
There was a problem hiding this comment.
at this point both values are the same as the defaults so it could be removed - I used this to test it with multiple values to find the best settings.
cgoina
commented
Feb 26, 2025
| handler: src/main/nodejs/monitor.monitorHandler | ||
| memorySize: 128 | ||
| timeout: ${self:custom.defaultJobTimeoutSecs} | ||
| environment: | ||
| DEBUG: ${self:custom.debug} | ||
| JOB_TIMEOUT_SECS: ${self:custom.defaultJobTimeoutSecs} | ||
| TASKS_TABLE_NAME: ${self:custom.tasksTable} | ||
|
|
||
|
|
||
| stepFunctions: |
There was a problem hiding this comment.
This is the biggest and the most important change
cgoina
commented
Feb 26, 2025
| environment: | ||
| DEBUG: ${self:custom.debug} | ||
|
|
||
| cleanupBatch: |
There was a problem hiding this comment.
I tried an automatic time to live for batch inputs but those files were never cleaned up so I added an explicit task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes changes so that we can migrate the burst compute to node18 and newer AWS backends.
Node18 requires aws sdk javascript v3 which no longer supports async lambda invocation so the old framework was replaced with a more complex step function that distributes the work using a Map state.