Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up linting #95

Merged
merged 11 commits into from
Aug 14, 2024
Merged

Tidy up linting #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cba7e1c
Add --fix to ruff linter in pre-commit
thomasaarholt Aug 14, 2024
73bd5e9
Don't use Sequence in BaseModel, ok to use list instead
thomasaarholt Aug 14, 2024
117124d
Set sensible config for pyright and ruff
thomasaarholt Aug 14, 2024
d973412
add UP to ruff config
thomasaarholt Aug 14, 2024
e2c0a66
Prevent ruff UP from upgrading syntax within BaseModel
thomasaarholt Aug 14, 2024
f52b74f
ruff UP test_dtypes without changing Sequence import
thomasaarholt Aug 14, 2024
ef03ecd
Ruff UP the entire codebase
thomasaarholt Aug 14, 2024
6a61f47
Update what is run on pre-commit and remove unused plugins
thomasaarholt Aug 14, 2024
2c56afb
update lockfile
thomasaarholt Aug 14, 2024
688fe13
Add noqa UP007 to BaseModel to prevent transforming to X | Y annotations
thomasaarholt Aug 14, 2024
6dc6ccd
Run ruff correctly
thomasaarholt Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ repos:
hooks:
# Run the linter.
- id: ruff
args: [ --fix ]
# Run the formatter.
- id: ruff-format
11 changes: 3 additions & 8 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import nox # type: ignore

nox.options.sessions = (
# "lint",
"lint",
"test",
# "type_check"
"docs",
Expand Down Expand Up @@ -107,16 +107,11 @@ def lint(session):
args = session.posargs or locations
install_with_constraints(
session,
"flake8",
"flake8-annotations",
"flake8-bandit",
"flake8-bugbear",
"flake8-docstrings",
"darglint",
"ruff",
)
session.run("flake8", *args)
session.run("ruff check", *args)
session.run("ruff", "check", *args)
session.run("ruff", "format", *args)


@nox.session(python="3.12")
Expand Down
Loading
Loading