support inheritance across modules. Issue #808. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanenicolas
force-pushed
the
sni/support-inheritance-in-modules
branch
from
308ffdd
to
664f760
Compare
stephanenicolas
changed the title
stephanenicolas
changed the title
stephanenicolas
changed the title
stephanenicolas
changed the title
WOLVIE97
approved these changes
Nov 3, 2017
This was referenced Mar 19, 2018
|
shopquannamdangcap |
opsenes
reviewed
Nov 9, 2018
| @@ -367,6 +369,12 @@ | |||
| bindingMap.put(type, builder.build()); | |||
| } else { | |||
| BindingSet parentBinding = bindingMap.get(parentType); | |||
|
|
|||
| // parent binding is null, let's try to find a previouly generated binding | |||
oldergod
reviewed
Feb 6, 2019
| BindingSet.Builder parentBuilder = BindingSet.newBuilder(parentType); | ||
| if (hasViewBindings(parentType)) { | ||
| //add a fake field to the parent class so that it will indicate it has a view bindings. | ||
| //this is required for the subclass to generate a proper view binder |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
We would appreciate your feedback on this PR about both the idea of the solution and its implementation, tests, etc.