Support incremental annotation processing. #1230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanenicolas
commented
Mar 26, 2018
| @@ -209,6 +213,10 @@ | |||
| return false; | |||
| } | |||
|
|
|||
| public HashMap<String, List<Element>> getMapGeneratedFileToOriginatingElements() { | |||
There was a problem hiding this comment.
/**package-private*/ @VisibleForTesting would make more sense.
|
@stephanenicolas Are you sure, that ButterKnife can be considered "isolating"? It appears to analyze the autogenerated R classes under some circumstances (such as when used in library project), so at very least it should be "aggregating". To make matters worse, it is currently using javac-internal APIs ( |
|
@Alexander-- I think it doesn't impact, but I am not sure. From what I see, R2 is not generated by the AP but by the butterknife plugin. And the plugin will generate R2 before compilation (the task is registered as a java generating taks). As soon as R changes, R2 is generated again and when processing a class using R2 values, they are inlined by the compiler, so I don't think it makes sense to say that a generated class depends on R2. I don't think we would add any valuable information to gradle. IF R doesn't chagne we are using the old values of R2. So, yeah, I am pretty confident that BK AP is isolating. |
|
@stephanenicolas I was worried if Gradle's |
|
If it only looks at the R class because its constants are referenced by the annotated files, then that's fine, because as soon as R changes, the annotated class will be recompiled. If a processor looked up R "out of the blue", with no connection to an annotated element (e.g. to decide whether to generated some class at all), then that would be a different story. That being said, I haven't read the code deeply, I'm just using my user-facing understanding of BK. |
|
The first commit looks good to me. I tested it locally and it seems to work well. Hopefully this will be the first incremental AP! |
|
@stephanenicolas And did you test the speed improvements when butter knife supports incremental compile. My build currently takes several minutes, so I'm looking for this like salvation. |
|
As Alexander pointed out, using |
|
@tprochazka yes it really works well and incremental compilation just works. Of course it's faster. But if you wait for salvation, I would recommend modularizing your code. Yes, it's long, difficult and painful but it gives great results. |
|
I made a few improvements to the processor in #1244 . They should help on top of the incremental ap logic. It may make the incremental logic even better as butterknife no longer looks at all fields in R2 classes |
|
I see that in the ButterKnife repository is quite a lot of open pull requests. |
|
@stephanenicolas What is the status of this pull request? |
|
I am not the one to ask.. :)
2018-04-18 4:13 GMT-07:00 Tomáš Procházka <[email protected]>:
… @stephanenicolas <https://github.com/stephanenicolas> What is the status
of this pull request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv33b2mfMF17idpIsg0jPW6xy5SS1B3ks5tpx_VgaJpZM4S5yxk>
.
|
|
Open
…On Wed, Apr 18, 2018, 8:40 AM Stéphane Nicolas ***@***.***> wrote:
I am not the one to ask.. :)
2018-04-18 4:13 GMT-07:00 Tomáš Procházka ***@***.***>:
> @stephanenicolas <https://github.com/stephanenicolas> What is the status
> of this pull request?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#1230 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABv33b2mfMF17idpIsg0jPW6xy5SS1B3ks5tpx_VgaJpZM4S5yxk
>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEbLp3wb3irt2JnSIhXh1pWEq9s2sks5tpzRGgaJpZM4S5yxk>
.
|
|
But there is merge conflict, which can fix only the author of the pull request. |
|
I would really like to get some feedback, the PR has been open for a while
and I don't wanna rebase it every time master changes.
I am very open to do it, I just wanna make sure the PR has chances to get
accepted.
2018-04-19 4:06 GMT-07:00 Tomáš Procházka <[email protected]>:
… But there is merge conflict, which can fix only the author of the pull
request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv33SLqEGyvoRSSHbdUsrvim0eHcHoKks5tqG_OgaJpZM4S5yxk>
.
|
|
Gradle 4.7 is already out. I think that now this is the most important thing for every library using annotation processing. Recompilation whole project on every small change takes 35s for me and I think that I'm not working on the biggest project. |
|
Android-State is now first Android lib with incremental compilation support! |
|
So it looks that Google team added support for incremental compilation to annotation processors included in build plugin itself. https://androidstudio.googleblog.com/2018/09/android-studio-33-canary-11-available.html Any chance that this pull request will be merged and at least snapshot build will be available? |
|
Hey guys, what's the state of this? Would love to see butterknife opt into incremental compilation sooner than later :) |
|
Try butterknife-reflect. It's 100% faster than incremental annotation
processing for your IDE builds.
…On Thu, Oct 18, 2018 at 2:39 PM Tony Robalik ***@***.***> wrote:
Hey guys, what's the state of this? Would love to see butterknife opt into
incremental compilation sooner than later :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEbAiz2RlJOGWIjIJiGFpemwjED_mks5umMrUgaJpZM4S5yxk>
.
|
|
That's fine by me. I'm just advocating on behalf of all the people still using Butterknife AP. If using butterknife-reflect is the preferred solution, maybe it's worth updating the readme to suggest that? There's nothing in the top-level readme to encourage users to switch to that instead. |
|
Here's a reason why NOT to use butterknife-reflect: #1391 |
|
PRs for missing functionality are welcome.
…On Mon, Nov 5, 2018, 3:14 PM Damjan Cvetko ***@***.*** wrote:
Here's a reason why NOT to use butterknife-reflect: #1391
<#1391>
Test what you fly...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEddYaLhPZY3tjKmxHw0YfBnET5gwks5usMZzgaJpZM4S5yxk>
.
|
This is PR with missing functionality :-( |
|
I was referring to the reflect runtime
…On Fri, Nov 16, 2018, 5:53 PM Tomáš Procházka ***@***.*** wrote:
PRs for missing functionality are welcome.
This is PR with missing functionality :-(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEX6LlfZZ8TQgA-XjFnIS8LPxZLCdks5uv0HugaJpZM4S5yxk>
.
|
|
Maybe would be great to reconsider finish this pull request, when reflect runtime is almost impossible to use because of #1364 |
|
I would like to see that happening too. The PR is close to be merged IMHO
…On Wed., Dec. 19, 2018, 17:29 Tomáš Procházka ***@***.*** wrote:
Maybe would be great to reconsider finish this pull request, when reflect
runtime is almost impossible to use because of #1364
<#1364>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv33dB68aVxyyF0thro-hFPIcd9eAs_ks5u6mlugaJpZM4S5yxk>
.
|
|
@JakeWharton and/or other contributors. Can we have a transparent, open and in-depth discussion on this PR ? It looks like there are some reasons on the maintainers side not to merge it and this PR has received some support from the community. Can we talk about it, and maybe figure out an even better solution ? |
|
If there is concern about the safety of this, butterknife could always follow dagger's lead and make it an opt-in feature. |
|
Can you send a link to a PR / GH issue about this Tony please ?
Le sam. 5 janv. 2019 à 22:08, Tony Robalik <[email protected]> a
écrit :
… If there is concern about the safety of this, butterknife could always
follow dagger's lead and make it an opt-in feature.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv33UXXhT7_SlTcTxpnba-jX50AI912ks5vARRQgaJpZM4S5yxk>
.
|
|
Thx @autonomousapps |
|
If you are interested, I got a fork of butterknife with incremental annotation processing available (+inheritance across modules which is a related issue). The artifacts are on maven central: com.github.stephanenicolas:butterknife*: https://search.maven.org/search?q=a:butterknife In the fork, all class names and packages have been preserved, using the fork is as simple as changing the artifacts names. |
|
I just tried to use and for some unknown reason it always fail on all @BindView annotation with error Tried it anybody else already? |
|
@tprochazka can you give more of the stacktrace please. I don't see this issue at all. Ideally something that explains what is the issue. You can use We don't experience this issue at all. Also make sure you change all butterknife libs, not only the 2 above. I mean annotations too, etc.. if needed. Then do a clean build, and then you should get it working. |
|
All other libs are referenced by main one. I tried check it by dependencies task and there is no I'm using android build plugin 3.3.0 and Gradle 4.10.2 currently on this project. annotation processor classpath looks like this And here is whole stacktrace: |
|
I will check it out tomorrow. The code is available on GH if you wanna have
a look.
…On Sat., Jan. 26, 2019, 17:06 Tomáš Procházka ***@***.*** wrote:
All other libs are referenced by main one. I tried check it by
dependencies task and there is no com.jakewharton dependency at all. So
I'm not sure what you mean.
I'm using android build plugin 3.3.0 and Gradle 4.10.2 currently on this
project.
annotation processor classpath looks like this
+--- com.github.stephanenicolas:butterknife-compiler:10.0.0-INCAP
| +--- com.squareup:javapoet:1.10.0 -> 1.11.1
| +--- com.github.stephanenicolas:butterknife-annotations:10.0.0-INCAP
| | \--- androidx.annotation:annotation:1.0.0
| +--- com.google.auto:auto-common:0.10
| | \--- com.google.guava:guava:23.5-jre -> 24.0-jre
| | +--- com.google.code.findbugs:jsr305:1.3.9
| | +--- org.checkerframework:checker-compat-qual:2.0.0
| | +--- com.google.errorprone:error_prone_annotations:2.1.3
| | +--- com.google.j2objc:j2objc-annotations:1.1
| | \--- org.codehaus.mojo:animal-sniffer-annotations:1.14
| \--- com.google.guava:guava:24.0-jre (*)
\--- com.evernote:android-state-processor:1.4.1
\--- com.squareup:javapoet:1.11.1
And here is whole stacktrace:
01:53:50.745 [ERROR] [system.err] ...HintView.java:143: error: Unable to generate view binder for @OnClick.
01:53:50.745 [ERROR] [system.err] void onGotItButtonClicked() {
01:53:50.745 [ERROR] [system.err] ^
01:53:50.745 [ERROR] [system.err]
01:53:50.745 [ERROR] [system.err] java.lang.NullPointerException
01:53:50.745 [ERROR] [system.err] at butterknife.compiler.ButterKnifeProcessor.elementToIds(ButterKnifeProcessor.java:1364)
01:53:50.746 [ERROR] [system.err] at butterknife.compiler.ButterKnifeProcessor.parseListenerAnnotation(ButterKnifeProcessor.java:1240)
01:53:50.746 [ERROR] [system.err] at butterknife.compiler.ButterKnifeProcessor.findAndParseListener(ButterKnifeProcessor.java:1051)
01:53:50.746 [ERROR] [system.err] at butterknife.compiler.ButterKnifeProcessor.findAndParseTargets(ButterKnifeProcessor.java:355)
01:53:50.746 [ERROR] [system.err] at butterknife.compiler.ButterKnifeProcessor.process(ButterKnifeProcessor.java:194)
01:53:50.746 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.processing.DelegatingProcessor.process(DelegatingProcessor.java:62)
01:53:50.746 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.processing.IsolatingProcessor.process(IsolatingProcessor.java:50)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:794)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:705)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.main.Main.compile(Main.java:523)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:129)
01:53:50.746 [ERROR] [system.err] at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:138)
01:53:50.746 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.AnnotationProcessingCompileTask.call(AnnotationProcessingCompileTask.java:89)
01:53:50.746 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.ResourceCleaningCompilationTask.call(ResourceCleaningCompilationTask.java:57)
01:53:50.746 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:50)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:36)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.delegateAndHandleErrors(NormalizingJavaCompiler.java:100)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:52)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:38)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.AnnotationProcessorDiscoveringCompiler.execute(AnnotationProcessorDiscoveringCompiler.java:49)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.AnnotationProcessorDiscoveringCompiler.execute(AnnotationProcessorDiscoveringCompiler.java:35)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.CleaningJavaCompilerSupport.execute(CleaningJavaCompilerSupport.java:39)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.compile.CleaningJavaCompilerSupport.execute(CleaningJavaCompilerSupport.java:27)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.tasks.compile.JavaCompile.performCompilation(JavaCompile.java:153)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.tasks.compile.JavaCompile.compile(JavaCompile.java:138)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.tasks.compile.JavaCompile.compile(JavaCompile.java:110)
01:53:50.747 [ERROR] [system.err] at com.android.build.gradle.tasks.ProcessAnnotationsTask.compile(ProcessAnnotationsTask.kt:90)
01:53:50.747 [ERROR] [system.err] at sun.reflect.GeneratedMethodAccessor916.invoke(Unknown Source)
01:53:50.747 [ERROR] [system.err] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
01:53:50.747 [ERROR] [system.err] at java.lang.reflect.Method.invoke(Method.java:498)
01:53:50.747 [ERROR] [system.err] at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.project.taskfactory.IncrementalTaskAction.doExecute(IncrementalTaskAction.java:50)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:39)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:26)
01:53:50.747 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:131)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:120)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:99)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
01:53:50.748 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.run(EventFiringTaskExecuter.java:51)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292)
01:53:50.748 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174)
01:53:50.749 [ERROR] [system.err] at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
01:53:50.749 [ERROR] [system.err] at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
01:53:50.749 [ERROR] [system.err] at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:46)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.LocalTaskInfoExecutor.execute(LocalTaskInfoExecutor.java:42)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareWorkItemExecutor.execute(DefaultTaskExecutionGraph.java:277)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareWorkItemExecutor.execute(DefaultTaskExecutionGraph.java:262)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$ExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:135)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$ExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:130)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$ExecutorWorker.execute(DefaultTaskPlanExecutor.java:200)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$ExecutorWorker.executeWithWork(DefaultTaskPlanExecutor.java:191)
01:53:50.749 [ERROR] [system.err] at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$ExecutorWorker.run(DefaultTaskPlanExecutor.java:130)
01:53:50.749 [ERROR] [system.err] at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
01:53:50.749 [ERROR] [system.err] at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
01:53:50.749 [ERROR] [system.err] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
01:53:50.749 [ERROR] [system.err] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
01:53:50.749 [ERROR] [system.err] at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
01:53:50.749 [ERROR] [system.err] at java.lang.Thread.run(Thread.java:748)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv33X_bYDTpWLxKzWVK6ggXbsaMsUJlks5vHPuYgaJpZM4S5yxk>
.
|
|
@tprochazka I can't repro the issue and this part of BK is not supposed to have changed in my fork. |
|
@tprochazka do you still have this issue ? |
|
Sorry for the delay. And yes, with |
|
I tested it on a different project with the same result, then I created a sample project just by AS wizard and just replace findViewById() with your forked ButterKnife and it has the same issue. |
|
Please discuss problems with a fork on that fork's issues
…On Thu, Jan 31, 2019 at 5:06 PM Tomáš Procházka ***@***.***> wrote:
I tested it on a different project with the same result, then I created a
sample project just by AS wizard and just replace findViewById() with your
forked ButterKnife and it has the same issue.
Here is source code
https://www.dropbox.com/s/5neciycvsuubs7s/butterknife-incap-test.zip?dl=1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEERkNcyoUCd3ZCugcLVHiF6ZzfCpUks5vI2j3gaJpZM4S5yxk>
.
|
|
I just enabled the issues on https://github.com/stephanenicolas/butterknife. Also, I was able to repro in the sample of TP 2 (which is also becoming incremental..). Feel free to create the issue in the fork's repo. The bug has been fixed and the fork of butterknife (now named butterfork :)) is working just fine with incremental annotation processing. |
oldergod
reviewed
Feb 6, 2019
| @@ -22,6 +22,8 @@ | |||
| import java.util.List; | |||
| import java.util.Map; | |||
| import java.util.Set; | |||
|
|
|||
| import java.util.LinkedHashMap; | ||
| import java.util.LinkedHashSet; | ||
| import java.util.List; | ||
| import java.util.HashSet; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
| import org.junit.Test; | ||
|
|
||
| import java.util.List; |
| import javax.tools.JavaFileObject; | ||
| import javax.tools.StandardLocation; | ||
|
|
| @@ -3,14 +3,21 @@ | |||
| import butterknife.compiler.ButterKnifeProcessor; | |||
| import com.google.common.collect.ImmutableList; | |||
| import com.google.testing.compile.JavaFileObjects; | |||
|
|
|||
| import javax.lang.model.element.Element; | |||
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-4.7-20180323002511+0000-bin.zip | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #1225
With #1045, the support for incremental annotation processing is complete.
It would be really nice to see 9.0.0 released with this soon ;)
(let me know if I can help)