Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable casing for entry types #9883

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We replaced the [OttoBib](https://en.wikipedia.org/wiki/OttoBib) fetcher by a fetcher by [OpenLibrary](https://openlibrary.org/dev/docs/api/books). [#8652](https://github.com/JabRef/jabref/issues/8652)
- We first fetch ISBN data from OpenLibrary, if nothing found, ebook.de is tried.
- We now only show a warning when exiting for tasks that will not be recovered automatically upon relaunch of JabRef. [#8468](https://github.com/JabRef/jabref/issues/8468)
- We enabled casing when adding field for entry type. [#9840](https://github.com/JabRef/jabref/issues/9840)

### Fixed

Expand Down
6 changes: 5 additions & 1 deletion src/main/java/org/jabref/model/entry/field/Field.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ public interface Field {
/**
* @return A version of the field name more suitable for display
*/
// default String getDisplayName() {
// return StringUtil.capitalizeFirst(getName());
// }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove artifacts instead of commenting it. This is what a VCS like git is made for.

default String getDisplayName() {
return StringUtil.capitalizeFirst(getName());
return getName();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this fixes the issue, it may also have unforseen consequences.
Better question is, where is this method called. Why is this method called instead of the method getName? Please provide some reasoning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, the solution is as simple as calling getName in the customize entry view model code


String getName();
Expand Down
22 changes: 22 additions & 0 deletions sxkeychain erase
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
credential.helper=osxkeychain
init.defaultbranch=main
user.name=eric052199
[email protected]
filter.lfs.process=git-lfs filter-process
filter.lfs.required=true
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
core.ignorecase=true
core.precomposeunicode=true
remote.upstream.url=https://github.com/JabRef/jabref.git
remote.upstream.fetch=+refs/heads/main:refs/remotes/upstream/main
branch.main.remote=upstream
branch.main.merge=refs/heads/main
remote.origin.url=https://github.com/eric052199/jabref.git
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.eric-dev.remote=origin
branch.eric-dev.merge=refs/heads/eric-dev
Comment on lines +1 to +22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an artifact of you working on your PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i'm not really sure what this is about. Do i need to remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, remove this