-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable casing for entry types #9883
Changes from 4 commits
1596d12
9b28dec
afa1ff3
b71f461
676a84d
392c58e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,8 +16,12 @@ public interface Field { | |
/** | ||
* @return A version of the field name more suitable for display | ||
*/ | ||
// default String getDisplayName() { | ||
// return StringUtil.capitalizeFirst(getName()); | ||
// } | ||
|
||
default String getDisplayName() { | ||
return StringUtil.capitalizeFirst(getName()); | ||
return getName(); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although this fixes the issue, it may also have unforseen consequences. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe, the solution is as simple as calling getName in the customize entry view model code |
||
|
||
String getName(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
credential.helper=osxkeychain | ||
init.defaultbranch=main | ||
user.name=eric052199 | ||
[email protected] | ||
filter.lfs.process=git-lfs filter-process | ||
filter.lfs.required=true | ||
filter.lfs.clean=git-lfs clean -- %f | ||
filter.lfs.smudge=git-lfs smudge -- %f | ||
core.repositoryformatversion=0 | ||
core.filemode=true | ||
core.bare=false | ||
core.logallrefupdates=true | ||
core.ignorecase=true | ||
core.precomposeunicode=true | ||
remote.upstream.url=https://github.com/JabRef/jabref.git | ||
remote.upstream.fetch=+refs/heads/main:refs/remotes/upstream/main | ||
branch.main.remote=upstream | ||
branch.main.merge=refs/heads/main | ||
remote.origin.url=https://github.com/eric052199/jabref.git | ||
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/* | ||
branch.eric-dev.remote=origin | ||
branch.eric-dev.merge=refs/heads/eric-dev | ||
Comment on lines
+1
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be an artifact of you working on your PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, i'm not really sure what this is about. Do i need to remove this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, remove this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove artifacts instead of commenting it. This is what a VCS like git is made for.