Enable casing for entry types #9883
Conversation
ThiloteE
changed the title
calixtus
changed the title
| // default String getDisplayName() { | ||
| // return StringUtil.capitalizeFirst(getName()); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Please remove artifacts instead of commenting it. This is what a VCS like git is made for.
| default String getDisplayName() { | ||
| return StringUtil.capitalizeFirst(getName()); | ||
| return getName(); | ||
| } |
There was a problem hiding this comment.
Although this fixes the issue, it may also have unforseen consequences.
Better question is, where is this method called. Why is this method called instead of the method getName? Please provide some reasoning.
There was a problem hiding this comment.
Maybe, the solution is as simple as calling getName in the customize entry view model code
| credential.helper=osxkeychain | ||
| init.defaultbranch=main | ||
| user.name=eric052199 | ||
| [email protected] | ||
| filter.lfs.process=git-lfs filter-process | ||
| filter.lfs.required=true | ||
| filter.lfs.clean=git-lfs clean -- %f | ||
| filter.lfs.smudge=git-lfs smudge -- %f | ||
| core.repositoryformatversion=0 | ||
| core.filemode=true | ||
| core.bare=false | ||
| core.logallrefupdates=true | ||
| core.ignorecase=true | ||
| core.precomposeunicode=true | ||
| remote.upstream.url=https://github.com/JabRef/jabref.git | ||
| remote.upstream.fetch=+refs/heads/main:refs/remotes/upstream/main | ||
| branch.main.remote=upstream | ||
| branch.main.merge=refs/heads/main | ||
| remote.origin.url=https://github.com/eric052199/jabref.git | ||
| remote.origin.fetch=+refs/heads/*:refs/remotes/origin/* | ||
| branch.eric-dev.remote=origin | ||
| branch.eric-dev.merge=refs/heads/eric-dev |
There was a problem hiding this comment.
This seems to be an artifact of you working on your PR?
There was a problem hiding this comment.
Sorry, i'm not really sure what this is about. Do i need to remove this?
|
Thank you very much for your PR. There are some issues I tried to address above. |
koppor
added
the
status: changes required
Fixes #9840
This is an enhancement for #9840. (the third todo, currently still working on the second)
We enabled casing when adding field for entry type.
Compulsory checks