Tried smoothing temp data #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried smoothing the temperature data with running means for 3, 5, and 10 years (see issue #8). The results files are all virtually identical, with the only differences being very slight changes in beta and the objective function values being 0.1 less than in the initial experiment.
To determine if the lack of change is because of a bug, I decided to do an optim run on temperature data that was smoothed for a running mean of 50 years, but I still got similar results.
As far as I can tell, there isn't a bug in my code, but I definitely could have missed something. My best guess is that the lack of change in results is because the smoothed temperature MSEs are still much lower magnitude than the CO2 MSEs. These results could also have something to do with beta and Q10 being on the boundaries of the "box" of valid values.