Transition to Manifest v3 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
2 times, most recently
from
faf83bf
to
4363df0
Compare
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
from
4363df0
to
d091a02
Compare
ItsVipra
reviewed
Jun 17, 2023
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
from
709ce3b
to
fd5e780
Compare
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
from
fd5e780
to
555d897
Compare
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
6 times, most recently
from
5022542
to
4a689b8
Compare
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
4 times, most recently
from
1d1aecc
to
3ce6502
Compare
|
Note to self: fix scripts on windows. |
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
2 times, most recently
from
fc6e5ad
to
cd1ddfc
Compare
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
from
cd1ddfc
to
d102a5e
Compare
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
4 times, most recently
from
00256cb
to
e89e62a
Compare
nachtjasmin
commented
Jul 17, 2023
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
2 times, most recently
from
61b6a32
to
b4e06d7
Compare
nachtjasmin
force-pushed
the
14-transition-to-manifest-v3
branch
from
6804ef4
to
371781b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #14. This PR depends on #32 to be merged.
This PR migrates the extension to Manifest v3. Although the current manifest version (2) still works fine, we can expect that Google is pushing the new manifest version even more.
For us, this has only one big advantage: We don't need to request the permission to access all pages.
This might be seen as disadvantage, because it requires one click more, but personally, I love this.
It ensures that our extension cannot mess with other websites on it's own. The confirmation by the click, that this is really a Mastodon page, is huge.
TODO