Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to Manifest v3 #14

Open
ItsVipra opened this issue May 24, 2023 · 2 comments · May be fixed by #15
Open

Transition to Manifest v3 #14

ItsVipra opened this issue May 24, 2023 · 2 comments · May be fixed by #15

Comments

@ItsVipra
Copy link
Owner

ItsVipra commented May 24, 2023

When trying to run the addon in Chrome (113.0.5672.127) there are several problems at the moment:

  1. The 'browser_specific_settings' manifest key is not recognized
  2. Manifest v2 is no longer supported in chrome
  3. "browser" is not defined - use "chrome" instead of generic browser?

Originally posted by @ItsVipra in #4 (comment)


Manifest v2 is no longer supported in Chrome, so we should transition to v3 to support Chrome(ium).

Implementation

See https://extensionworkshop.com/documentation/develop/manifest-v3-migration-guide/

@ItsVipra ItsVipra added this to the v1.0 milestone May 25, 2023
@ItsVipra
Copy link
Owner Author

after much frustration i've come to the following conclusion:
manifest v3 on firefox is broken or something? doesn't request permissions correctly. Fediact (yes i reference that extension a lot) also uses manifest v2 for the firefox version exclusively.
it seems like nobody on firefox uses v3 if they don't have to, even big extensions like ublock. thanks for nothing google >:c

my best guess on how to handle this is to upgrade the manifest file to v3 for chrome and implement a toolchain that converts it back down to v2 for our firefox release

@ItsVipra ItsVipra modified the milestones: v1.0, Chrome Release May 25, 2023
@nachtjasmin nachtjasmin linked a pull request May 25, 2023 that will close this issue
2 tasks
@nachtjasmin nachtjasmin linked a pull request May 25, 2023 that will close this issue
2 tasks
@nachtjasmin
Copy link
Contributor

even though there’s some progress in #15, the upcoming Firefox release might make the transition easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants