-
Notifications
You must be signed in to change notification settings - Fork 26
Add golden transactions test to the local transaction submission server #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisdral
merged 6 commits into
main
from
137-add-golden-txs-test-for-localTxSubmissionServer
Jul 25, 2023
Merged
Add golden transactions test to the local transaction submission server #225
jorisdral
merged 6 commits into
main
from
137-add-golden-txs-test-for-localTxSubmissionServer
Jul 25, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
446a135
to
ff38371
Compare
jorisdral
reviewed
Jul 11, 2023
ouroboros-consensus/src/mempool-test-utils/Test/Consensus/Mempool/Mocked.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/cardano-testlib/Test/Consensus/Cardano/ProtocolInfo.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/cardano-testlib/Test/Consensus/Cardano/ProtocolInfo.hs
Show resolved
Hide resolved
...us-cardano/test/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/Server.hs
Outdated
Show resolved
Hide resolved
...us-cardano/test/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/Server.hs
Outdated
Show resolved
Hide resolved
dnadales
commented
Jul 12, 2023
...us-cardano/test/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/Server.hs
Outdated
Show resolved
Hide resolved
dnadales
commented
Jul 12, 2023
...us-cardano/test/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/Server.hs
Outdated
Show resolved
Hide resolved
jorisdral
approved these changes
Jul 12, 2023
dnadales
commented
Jul 12, 2023
...us-cardano/test/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/Server.hs
Outdated
Show resolved
Hide resolved
This commit creates the `mempool-test-utils` library, which at the moment contains only one module. The benchmarks use this library, and we plan on using it in other mempool tests.
... that can be used in the elaboration of `ProtocolInfo` types for testing purposes.
68edc41
to
c311626
Compare
For reference: sample Cardano ThreadNet test output:
|
amesgen
approved these changes
Jul 18, 2023
...est/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/ByteStringTxParser.hs
Outdated
Show resolved
Hide resolved
...est/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/ByteStringTxParser.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/cardano-testlib/Test/Consensus/Cardano/ProtocolInfo.hs
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/cardano-testlib/Test/Consensus/Cardano/ProtocolInfo.hs
Outdated
Show resolved
Hide resolved
...us-cardano/test/cardano-test/Test/Consensus/Cardano/MiniProtocol/LocalTxSubmission/Server.hs
Outdated
Show resolved
Hide resolved
462d9b7
to
31a2529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a test to detect errors in the Ledger code, like this one, early on.
Other changes include:
ProtocolInfo
for testing purposes. This protocol info is used when opening a Cardano mempool.