Skip to content

Update to ledger-api-1.6 and ledger-conway-1.9 #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Sep 19, 2023

Next major ledger release should be soon-ish and will likely be not too different from what is being integrated here.

  • Most of the diff is due to integrating the new TransitionConfig concept from Ledger, see Implement EraTransition cardano-ledger#3737.
    • Every Shelley-based era XEra c has a TransitionConfig (XEra c) that contains all Genesis information up until this era. In particular, one can get all previous TranslationContexts and TransitionConfigs up until this era from it.
    • They can be used to register initial funds and staking (benchmarking features whose implementation has now been moved to Ledger), and to create initial Shelley ledger states for pure Shelley-based chains.
    • We could keep the current interface to protocolInfoCardano the same (by assembling a Conway TransitionConfig from the given TranslationContexts), but Ledger wants to push the construction of the TransitionConfig downwards to Node etc (eg in order to be able to add more information to it, or even consolidate all Genesis files into one).
      This also actually makes things easier on our end, as this allows us to simplify the ProtocolTransitionParams.
  • Ledger state serialization and the Conway Genesis file format changed.

@amesgen amesgen mentioned this pull request Sep 19, 2023
@amesgen amesgen force-pushed the amesgen/ledger-conway-1.9 branch 2 times, most recently from a7038c3 to 0049df7 Compare September 19, 2023 13:28
@amesgen amesgen self-assigned this Sep 21, 2023
@amesgen amesgen force-pushed the amesgen/ledger-conway-1.9 branch 2 times, most recently from b5adf37 to c3af38d Compare September 25, 2023 13:19
@amesgen amesgen force-pushed the amesgen/ledger-conway-1.9 branch from d7b0c91 to cf382c5 Compare September 26, 2023 10:05
@amesgen amesgen changed the title Update to ledger-conway-1.9 Update to ledger-api-1.6 and ledger-conway-1.9 Sep 26, 2023
@amesgen amesgen force-pushed the amesgen/ledger-conway-1.9 branch from cf382c5 to 29c591b Compare September 26, 2023 14:18
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2¢ on the subject of initial configuration from the perspective of a user, having dealt with it on numerous occasions. It doesn't need to be that complicated. The simpler the better.

@amesgen amesgen force-pushed the amesgen/ledger-conway-1.9 branch 4 times, most recently from abbd83b to 27afdbd Compare September 27, 2023 11:47
@amesgen amesgen force-pushed the amesgen/ledger-conway-1.9 branch from 27afdbd to a1ae570 Compare September 27, 2023 12:10
@amesgen amesgen marked this pull request as ready for review September 27, 2023 12:27
@amesgen amesgen requested a review from a team as a code owner September 27, 2023 12:27
@amesgen amesgen enabled auto-merge September 27, 2023 12:38
@amesgen amesgen added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 2109940 Sep 27, 2023
@amesgen amesgen deleted the amesgen/ledger-conway-1.9 branch September 27, 2023 16:45
@amesgen amesgen mentioned this pull request Oct 2, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants