-
Notifications
You must be signed in to change notification settings - Fork 26
Update to ledger-api-1.6 and ledger-conway-1.9 #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
a7038c3
to
0049df7
Compare
10 tasks
b5adf37
to
c3af38d
Compare
9 tasks
d7b0c91
to
cf382c5
Compare
cf382c5
to
29c591b
Compare
dnadales
reviewed
Sep 26, 2023
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Show resolved
Hide resolved
dnadales
reviewed
Sep 26, 2023
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Show resolved
Hide resolved
dnadales
reviewed
Sep 26, 2023
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Outdated
Show resolved
Hide resolved
dnadales
reviewed
Sep 26, 2023
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Outdated
Show resolved
Hide resolved
dnadales
reviewed
Sep 26, 2023
ouroboros-consensus-cardano/src/unstable-cardano-testlib/Test/Consensus/Cardano/ProtocolInfo.hs
Outdated
Show resolved
Hide resolved
dnadales
approved these changes
Sep 26, 2023
lehins
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2¢ on the subject of initial configuration from the perspective of a user, having dealt with it on numerous occasions. It doesn't need to be that complicated. The simpler the better.
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Show resolved
Hide resolved
abbd83b
to
27afdbd
Compare
Co-authored-by: Alexey Kuleshevich <[email protected]>
27afdbd
to
a1ae570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next major ledger release should be soon-ish and will likely be not too different from what is being integrated here.
TransitionConfig
concept from Ledger, see Implement EraTransition cardano-ledger#3737.XEra c
has aTransitionConfig (XEra c)
that contains all Genesis information up until this era. In particular, one can get all previousTranslationContext
s andTransitionConfig
s up until this era from it.protocolInfoCardano
the same (by assembling a ConwayTransitionConfig
from the givenTranslationContext
s), but Ledger wants to push the construction of theTransitionConfig
downwards to Node etc (eg in order to be able to add more information to it, or even consolidate all Genesis files into one).This also actually makes things easier on our end, as this allows us to simplify the
ProtocolTransitionParams
.