Add the core of the ordinary index support

[jeltsch]

This adds support for the ordinary index apart from serialization.

[jorisdral]

This adds support for the ordinary index apart from serialization.

Another missing feature is incremental construction, or is that included in the serialisation?

Are you planning on adding tests in a follow-up PR?

[jeltsch]

Another missing feature is incremental construction, or is that included in the serialisation?

I understood that serialization is supposed to be incremental and thus incremental construction is entangled with serialization. Consequently, I wanted to include incremental construction in the serialization part. Did I get something wrong here?

Are you planning on adding tests in a follow-up PR?

The testing issue is an interesting one. My understanding is that there should ultimately be a common interface for indexes, with instances for the compact and the ordinary index. Tests could and perhaps should then be written for indexes as such, using said interface, and run for the different instances. My impression is that adding tests specifically for the ordinary index would merely boil down to copying compact-index tests, which wouldn’t seem like a good idea to me. What are your thoughts about this?

[jorisdral]

Another missing feature is incremental construction, or is that included in the serialisation?

I understood that serialization is supposed to be incremental and thus incremental construction is entangled with serialization. Consequently, I wanted to include incremental construction in the serialization part. Did I get something wrong here?

Sure, that's true, the two are closely related, but not exactly the same. I was just wondering why you mentioned that only serialisation was missing

Are you planning on adding tests in a follow-up PR?

The testing issue is an interesting one. My understanding is that there should ultimately be a common interface for indexes, with instances for the compact and the ordinary index. Tests could and perhaps should then be written for indexes as such, using said interface, and run for the different instances. My impression is that adding tests specifically for the ordinary index would merely boil down to copying compact-index tests, which wouldn’t seem like a good idea to me. What are your thoughts about this?

Having at least one simple property test to give us some assurance that search is working would be nice to have, but sure in the end we could have tests that can run against all types of indexes. A little bit of duplication for now is not a bad thing

[jeltsch]

Having at least one simple property test to give us some assurance that search is working would be nice to have […]. A little bit of duplication for now is not a bad thing

I’ve filed issue #265 to deal with this.