Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CertState to a type family #4861

Merged
merged 18 commits into from
Feb 20, 2025
Merged

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Jan 30, 2025

Description

Resolves #4693

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick skim over the PR and it looks awesome.
There is one important point that I made that will need to be address that has to do with a common issue of changes getting lost during rebasing, but that shouldn't be too hard.
I'll do a proper review once the PR is out of the Draft state.

@Lucsanszky Lucsanszky force-pushed the ldan/certstate-type-family branch 23 times, most recently from ea8e6b9 to dc553dd Compare February 15, 2025 01:29
@Lucsanszky Lucsanszky marked this pull request as ready for review February 15, 2025 01:42
@Lucsanszky Lucsanszky requested a review from a team as a code owner February 15, 2025 01:42
@Lucsanszky
Copy link
Contributor Author

Finally, this is now ready for review. I opted not to detail every little change in the changelogs but rather indicate the affected packages that CertState was converted to a type family.

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a very nice piece of work.
Thank you!

I've created a follow up ticket that will track the other half of the work that needs to be done with respect to CertState

@Lucsanszky Lucsanszky force-pushed the ldan/certstate-type-family branch from 689e41f to 326e7e1 Compare February 19, 2025 03:26
@Lucsanszky Lucsanszky force-pushed the ldan/certstate-type-family branch from 326e7e1 to 8cae046 Compare February 20, 2025 00:07
@Lucsanszky Lucsanszky force-pushed the ldan/certstate-type-family branch from 8cae046 to 12459df Compare February 20, 2025 00:07
@Lucsanszky Lucsanszky enabled auto-merge (squash) February 20, 2025 00:39
@Lucsanszky Lucsanszky merged commit 9f98a9e into master Feb 20, 2025
152 of 154 checks passed
@Lucsanszky Lucsanszky deleted the ldan/certstate-type-family branch February 20, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CertState into a type family
2 participants