You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are slowly moving towards all state related functionality defined in Cardano.Ledger.[Era].State sub modules. This needs to be applied to CertState as well.
Create ConwayCertState
Move VState out of ShelleyCertState into the new ConwayCertState
Move VState into cardano-ledger-conway
VState has no business being defined in cardano-ledger-core and needs to migrate into cardano-ledger-conway package
mkCertState
We can't use mkCertState that accepts VState as an argument, because VState will not be available in shelley era.
This isn't really a problem since we can always construct it from an empty CertState, eg:
Move into
Cardano.Ledger.[Era].State.CertState
We are slowly moving towards all state related functionality defined in
Cardano.Ledger.[Era].State
sub modules. This needs to be applied toCertState
as well.Create
ConwayCertState
Move
VState
out ofShelleyCertState
into the newConwayCertState
Move
VState
intocardano-ledger-conway
VState
has no business being defined incardano-ledger-core
and needs to migrate intocardano-ledger-conway
packagemkCertState
We can't use
mkCertState
that accepts VState as an argument, becauseVState
will not be available in shelley era.This isn't really a problem since we can always construct it from an empty CertState, eg:
Then we can use
mkShelleyCertState
to definemkConwayCertState
But those will have to be standalone functions and will not longer be part of the EraCertState type class.
Moreover in ledger rules we can always get away with modifying
CertState
, instead of constructing a new one.Originally posted by @lehins in #4861 (comment)
The text was updated successfully, but these errors were encountered: