SAM callback step/epoch skipping configuration #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
laserkelvin
added
ux
smiret-intel
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors SAM to allow the ability to specify a number of steps or epochs to delay sharpness awareness by adding the
skip_step_countandskip_epoch_countparameters to theSAM.__init__. The former accepts integers, which specifies the minimum number of steps to pass before SAM activates, while the latter accepts both integers and a fraction between [0,1].Additionally, a configurable logger has been added to
SAM, which informs the user when the gradient norm goes below machine epsilon, i.e. indicating numerical instability. Logging is not on by default.