SAM configuration check fixes #288

laserkelvin · 2024-09-10T17:29:33Z

This PR fixes bugs associated with the skip_* configuration options to the SAM callback introduced in #284:

Fixed the nothing logical comparison for skip_epoch_count and skip_epoch_count in __init__, which meant any value of skip_epoch_count would fail the assertion
Changed is_integer checks to isinstance(skip_epoch_count, float); this was a mistake from my IDE that confused me into thinking it was a method for float as well as strings.
Added a logging step that reports which epoch SAM when a fractional value is passed to skip_epoch_count

Signed-off-by: Lee, Kin Long Kelvin <[email protected]>

laserkelvin added 5 commits September 10, 2024 10:06

fix: correcting mutual exclusivity check

6f668a9

fix: correcting float check for epoch skip setting

8134387

fix: correcting is_integer check to float instance checking

dc3021e

refactor: configuring logger to report when SAM is expected to start

60a04e7

Signed-off-by: Lee, Kin Long Kelvin <[email protected]>

refactor: adding step configuration to SAM example

ff0a415

Signed-off-by: Lee, Kin Long Kelvin <[email protected]>

laserkelvin added bug Something isn't working training Issues related to model training labels Sep 10, 2024

laserkelvin requested review from melo-gonzo and smiret-intel September 10, 2024 17:29

melo-gonzo approved these changes Sep 10, 2024

View reviewed changes

laserkelvin merged commit 9ac8a65 into IntelLabs:main Sep 10, 2024
2 of 3 checks passed

laserkelvin deleted the sam-config-fixes branch September 10, 2024 18:00

Provide feedback