Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise the controller app #132

Merged
merged 30 commits into from
Oct 7, 2024
Merged

Initialise the controller app #132

merged 30 commits into from
Oct 7, 2024

Conversation

AdrianDAlessandro
Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro commented Oct 3, 2024

Description

This PR adds a simple controller app to the repo. All it has is an index view and is linked to the current project in INSTALLED_APPS. I have tried to make as few changes as possible so that it will not have conflicts with #131 and when #113 is tackled.

The first commit is what is auto-generated by python manage.py startapp controller. So if you want to see my customisations, ignore that commit.

Fixes #114

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6dca5bb) to head (ba75741).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           44        44           
=========================================
  Hits            44        44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Tiny tests question.

tests/utils.py Show resolved Hide resolved
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, however, as it is done, it seems that the current app (the process manager) is still the main app and the controller a dependent, somehow, based on the URL patterns and that the template is the one of the main app.

Possibly this is part of another PR, but I think that main should be setup as an app in parallel to the controller, with all the common templates in the root directly and the URLs symmetric, one process_manager/ and the other controller/.

@AdrianDAlessandro
Copy link
Contributor Author

This looks ok, however, as it is done, it seems that the current app (the process manager) is still the main app and the controller a dependent, somehow, based on the URL patterns and that the template is the one of the main app.

Possibly this is part of another PR, but I think that main should be setup as an app in parallel to the controller, with all the common templates in the root directly and the URLs symmetric, one process_manager/ and the other controller/.

Yes, that is to be tackled in #113

@AdrianDAlessandro AdrianDAlessandro mentioned this pull request Oct 4, 2024
10 tasks
Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

tests/utils.py Show resolved Hide resolved
@cc-a cc-a enabled auto-merge October 7, 2024 10:12
@cc-a cc-a merged commit ba0960f into main Oct 7, 2024
3 of 4 checks passed
@cc-a cc-a deleted the controller-app branch October 7, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialise controller app
5 participants