-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create process_manager app #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianDAlessandro
requested review from
dalonsoa,
jamesturner246,
TinyMarsh,
cc-a,
alexdewar and
Sahil590
October 4, 2024 16:15
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## controller-app #133 +/- ##
================================================
Coverage 100.00% 100.00%
================================================
Files 5 5
Lines 44 44
================================================
Hits 44 44 ☔ View full report in Codecov by Sentry. |
cc-a
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. htmx stuff still seems to be working.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a new app called
process_manager
and shifts all the behaviour for the process manager from themain
app to the new app. The only details remaining in the main app are:Some more details:
main
app index page still requires a login, all it shows is two buttons to navigate to the other apps from.process_manager
views and urls are namespaces under the path prefix/process_manager/
Caveat:
process_manager
will end up being common to thecontroller
, but this information is not yet known for sure. If that occurs in the future, we can simply shift things back to themain
app ass needed.This PR builds on #132 and should be merged after that.
Close #113
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks