Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create process_manager app #133

Merged
merged 19 commits into from
Oct 7, 2024
Merged

Create process_manager app #133

merged 19 commits into from
Oct 7, 2024

Conversation

AdrianDAlessandro
Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro commented Oct 4, 2024

Description

This PR creates a new app called process_manager and shifts all the behaviour for the process manager from the main app to the new app. The only details remaining in the main app are:

  • The user model (plus associated admin, migrations, and login template)
  • The base and navbar templates
  • The Kafka consumer management command

Some more details:

  • The main app index page still requires a login, all it shows is two buttons to navigate to the other apps from.
  • The process_manager views and urls are namespaces under the path prefix /process_manager/
  • The tests have been split into sub-folders for each app
  • The navbar template is newly separated out and has additional nav links to the two apps, which can only be viewed when authenticated

Caveat:

  • It's possible some of the behaviours currently in the process_manager will end up being common to the controller, but this information is not yet known for sure. If that occurs in the future, we can simply shift things back to the main app ass needed.

This PR builds on #132 and should be merged after that.
Close #113

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@AdrianDAlessandro
Copy link
Contributor Author

@cc-a Can you make sure I have merged this with #130 properly?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4a26086) to head (b78d0f6).

Additional details and impacted files
@@               Coverage Diff                @@
##           controller-app      #133   +/-   ##
================================================
  Coverage          100.00%   100.00%           
================================================
  Files                   5         5           
  Lines                  44        44           
================================================
  Hits                   44        44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. htmx stuff still seems to be working.

@cc-a cc-a merged commit 1db2be1 into controller-app Oct 7, 2024
4 checks passed
@cc-a cc-a deleted the process-manager-app branch October 7, 2024 10:12
@AdrianDAlessandro AdrianDAlessandro linked an issue Oct 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor main app
4 participants