Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coordinate for Measurement in SR #307

Merged
merged 9 commits into from
Oct 19, 2024
Merged

Add coordinate for Measurement in SR #307

merged 9 commits into from
Oct 19, 2024

Commits on Sep 26, 2024

  1. Add coordinate for Measurement in SR 

    This adds support for row 3 and 4 from TID 320.

Resolves ImagingDataCommons#306
    @Fedalto
    Fedalto committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    65eaf3b View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. fix import style 

    Co-authored-by: Chris Bridge <[email protected]>
    @Fedalto @CPBridge
    Fedalto and CPBridge authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    73452a1 View commit details
    Browse the repository at this point in the history

  2. Add Measurement.referenced_coordinates parameter 

    Extract the `CoordinatesForMeasurement` in its own parameter.

Add `CoordinatesForMeasurement.from_dataset`.
    @Fedalto
    Fedalto committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ab6bb55 View commit details
    Browse the repository at this point in the history

  3. Add purpose parameter to CoordinatesForMeasurement.__init__

    @Fedalto
    Fedalto committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    867cee4 View commit details
    Browse the repository at this point in the history

  4. Change SourceImageForRegion concept name to codes.SCT.Source 

    This follows the recommendation in the spec
    @Fedalto
    Fedalto committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    81dd8fb View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Only allow coordinates in measurements in `MeasurementsAndQualitative… 

    …Evaluations`

TID 1410 (Planar ROI Measurements and Qualitative Evaluations) and TID
1411 (Volumetric ROI Measurements and Qualitative Evaluations) make use
of TID 1419 (ROI Measurements) which does not include coordinates like
TID 300 (Measurements).
    @Fedalto
    Fedalto committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9f6d673 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Add CoordinatesForMeasurement3D

    @Fedalto
    Fedalto committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f97fe3a View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Change casting to use cls

    @CPBridge
    CPBridge authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1012fad View commit details
    Browse the repository at this point in the history

  2. Favour CoordinatesForMeasurement3D over Scoord3DContentItem

    @CPBridge
    CPBridge authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3aca8ff View commit details
    Browse the repository at this point in the history