Add coordinate for Measurement in SR #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for row 3 and 4 from TID 320. Resolves ImagingDataCommons#306
Fedalto
commented
Sep 26, 2024
| self, | ||
| graphic_type: Union[GraphicTypeValues, str], | ||
| graphic_data: np.ndarray, | ||
| source_image: SourceImageForRegion, |
There was a problem hiding this comment.
This has nothing to do with ImageRegion, but I reused SourceImageForRegion here as it needs to be an image with SELECTED FROM relationship. Not sure if there's a better option.
Fedalto
commented
Sep 26, 2024
| @@ -2386,7 +2386,7 @@ def __init__( | |||
| finding_sites: Optional[Sequence[FindingSite]] = None, | |||
| method: Optional[Union[CodedConcept, Code]] = None, | |||
| properties: Optional[MeasurementProperties] = None, | |||
| referenced_images: Optional[Sequence[SourceImageForMeasurement]] = None, | |||
| referenced_images: Optional[Sequence[Union[SourceImageForMeasurement, CoordinatesForMeasurement]]] = None, | |||
There was a problem hiding this comment.
I created another option and used the same referenced_images parameter.
Another solution I see would be to expand SourceImageForMeasurement and implement all options from TID 320 in it.
If a SCOORD is given, use row 3 and 4. If SCOORD3D, then make it use row 6 (I have not implemented this). If no coordinate is passed, use row 1 (which is the current SourceImageForMeasurement functionality)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for row 3 and 4 from TID 320.
Resolves #306