Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Fix: Unique session id #6335

Merged
merged 9 commits into from
Sep 10, 2024
Merged
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -992,11 +992,30 @@ qx.Class.define("osparc.utils.Utils", {
}
},

// Function that creates a unique tabId even for duplicated tabs
getClientSessionID: function() {
// https://stackoverflow.com/questions/11896160/any-way-to-identify-browser-tab-in-javascript
const clientSessionID = sessionStorage.getItem("clientsessionid") ? sessionStorage.getItem("clientsessionid") : osparc.utils.Utils.uuidV4();
sessionStorage.setItem("clientsessionid", clientSessionID);
return clientSessionID;
const getUniqueSessionId = () => {
const uuid = osparc.utils.Utils.uuidV4();
// Set window.name. This property is persistent on window reloads, but it doesn't get copied in a duplicated tab
window.name = uuid;
sessionStorage.setItem("clientsessionid", uuid);
return uuid;
};

let uniqueSessionId = sessionStorage.getItem("clientsessionid");
if (uniqueSessionId) {
// Check if the tab was duplicated
// window.name is one of the few things it doesn't get copied, but persists on window reload
if (window.name !== uniqueSessionId) {
// Tab has been duplicated, generate a new uniqueId for the duplicated tab
uniqueSessionId = getUniqueSessionId();
}
} else {
// If no tabId exists in sessionStorage, generate one
uniqueSessionId = getUniqueSessionId();
}

return uniqueSessionId;
},

getFreeDistanceToWindowEdges: function(layoutItem) {
Expand Down
Loading