🐛 [Frontend] Fix: Unique session id #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
requested review from
giancarloromeo,
GitHK,
pcrespov,
mguidon,
sanderegg and
matusdrobuliak66
sanderegg
reviewed
Sep 10, 2024
matusdrobuliak66
approved these changes
Sep 10, 2024
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Sep 10, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Changes the logic to create/get the clientsessionid. When a tab gets duplicated, the
sessionStorageandlocalStorageget also copied. When this happens, two different tabs would end up using the same sessionId, bringing the user to buggy scenarios.This PR updates the getClientSessionId function, which now also relies on the
window.name, which doesn't get copied when a tab is duplicated but it persists to window reloads.Related issue/s
closes #4363
How to test
Dev-ops checklist