Fix and simplify org name regex #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andylolz
force-pushed
the
fix-and-simplify-regex
branch
from
d164750 to
ca73931
Compare
This ought to be sufficient.
andylolz
force-pushed
the
fix-and-simplify-regex
branch
from
a48d52f to
bfdf823
Compare
andylolz
force-pushed
the
fix-and-simplify-regex
branch
from
bfdf823 to
0c8f02b
Compare
|
As for #59, this rule could equally be expressed by moving the conditional part out of the selector, and into a condition. For #59, the rule looks cleaner using a condition. For this one, I’m not so sure (I guess it would probably need to be split up into a couple of rules.) |
findall can’t cope with conditions, which are used in the org narrative rules. XPath is required.
andylolz
force-pushed
the
fix-and-simplify-regex
branch
from
30d8561 to
13b3526
Compare
|
The decided course of action is to not add this as a Machine Actionable Rule since the benefit is tiny (it doesn't really check anything super useful) given the complication in adding it. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that breaks; fixes it.
It’s worth bearing in mind that the regex matcher doesn’t have the
DOTALLflag set in either python or PHP, so you have to be careful when using it for text nodes likenarrative/text(), that may contain newlines. This actually (sort of) breaks^(?!\s*$).+, for instance.Refs #61; #56.