Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta tests for all new rules #61

Open
1 of 2 tasks
andylolz opened this issue Feb 6, 2018 · 2 comments
Open
1 of 2 tasks

Add meta tests for all new rules #61

andylolz opened this issue Feb 6, 2018 · 2 comments

Comments

@andylolz
Copy link
Contributor

andylolz commented Feb 6, 2018

I just tried adding meta tests (#59; #60; #62) for a couple of the new rules (#55; #56; #54), and found multiple bugs for each. So:

  • It’s probably worth adding new tests to meta_tests.sh for any new rules added. It’s probably not strictly correct, because the meta tests are for test coverage, not rule coverage, but it is useful.
  • It may be worth covering the rulesets (or at least the standard ruleset).
@samuele-mattiuzzo
Copy link
Contributor

@andylolz we'll look into this at the end of this sprint (Monday, basically), so I might ping you about this if there's any more work needed 👍

rolfkleef referenced this issue in data4development/IATI-Rulesets Jan 9, 2020
@akmiller01
Copy link
Contributor

Looks like quite a bit of work was done to this file shortly after Sam's comment: https://github.com/IATI/IATI-Rulesets/commits/version-2.02/meta_tests.sh

And tests are now run with GH Actions: https://github.com/IATI/IATI-Rulesets/blob/version-2.03/.github/workflows/main.yml#L52

So I think this issue can be closed unless there's a facet I'm missing @andylolz ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants