Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LEAP-1615: LEAP-456: Fix tool unselect #6630

Merged
merged 8 commits into from
Nov 19, 2024
Merged

fix: LEAP-1615: LEAP-456: Fix tool unselect #6630

merged 8 commits into from
Nov 19, 2024
+41 −24

Commits on Nov 11, 2024

  1. fix: LEAP-1615: Fix tool unselect 

    Pan was blocking the app upon unselection, because there were no tools selected after this.
When drawing tools are not displayed (like in usual RectangleLabels case) then it's hard to start drawing again.
    @hlomzik
    hlomzik committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8d2f13d View commit details
    Browse the repository at this point in the history

  2. Also make Move tool unselectable 

    The same way as Pan tool: default tool will be selected.
    @hlomzik
    hlomzik committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f7c1fcb View commit details
    Browse the repository at this point in the history

  3. Also fix smart tools selection 

    If user clicks on exact icon in popup panel the next tool is actually selected,
because there are two handlers active at this moment.
Fix this by blocking the more general one, used to rotate through all smart tools.
    @hlomzik
    hlomzik committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    07068c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge branch 'develop' into 'fb-leap-1615/tools' 

    Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11814123871
    @MihajloHoma
    MihajloHoma committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9dad9a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Fix aria-label to match the auto generated one 

    It's used in tests and they are failing now, because naming was changed
    @hlomzik
    hlomzik authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1a8af69 View commit details
    Browse the repository at this point in the history

  2. Make selectTool() more readable

    @hlomzik
    hlomzik authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a1b8d2d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Fix tests

    @hlomzik
    hlomzik committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3917bb8 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Fix hotkey handler

    @hlomzik
    hlomzik committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e04178e View commit details
    Browse the repository at this point in the history