You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pan was blocking the app upon unselection, because there were no tools selected after this. When drawing tools are not displayed (like in usual RectangleLabels case) then it's hard to start drawing again.
Also Selection tool (aka Move tool) was switched to the same behavior, allowing users to unselect it. The default tool will be selected then.
Also Smart tools selection is fixed — when you click on exact tool it's selected without weird jumps and rotation through other tools.
tools-improved.mov
PR fulfills these requirements
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
Product design
Backend (Database)
Backend (API)
Frontend
Describe the reason for change
Users can be stuck after using Pan tool and unselecting it. Also that's inconsistent with Move tool.
Does this change affect performance?
nope
Does this change affect security?
nope
What alternative approaches were there?
Make Pan tool also not unselectable like Move tool. But for cases without drawing tools visible that would make it worse.
Pan was blocking the app upon unselection, because there were no tools selected after this.
When drawing tools are not displayed (like in usual RectangleLabels case) then it's hard to start drawing again.
If user clicks on exact icon in popup panel the next tool is actually selected,
because there are two handlers active at this moment.
Fix this by blocking the more general one, used to rotate through all smart tools.
hlomzik
changed the title
fix: LEAP-1615: Fix tool unselect
fix: LEAP-1615: LEAP-456: Fix tool unselect
Nov 11, 2024
The reason will be displayed to describe this comment to others. Learn more.
approved! one point - isSeparated and iconComponent are both removed - are they no longer used anywhere?
as an aside, its been a long time since i touched anything editor and I dont remember off hand if we have tests specifically for the different tools and tags - if not would be great to see more tests for that in a seperate ticket
isSeparated and iconComponent are both removed - are they no longer used anywhere?
@yyassi-heartex they are used when we render base tool via ToolView in tools/Base.jsx. and I switched Move tool to render its custom tag like we do in some other tools, so we don't need these params
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hlomzik
changed the title
Pan was blocking the app upon unselection, because there were no tools selected after this. When drawing tools are not displayed (like in usual RectangleLabels case) then it's hard to start drawing again.
Also Selection tool (aka Move tool) was switched to the same behavior, allowing users to unselect it. The default tool will be selected then.
Also Smart tools selection is fixed — when you click on exact tool it's selected without weird jumps and rotation through other tools.
tools-improved.mov
PR fulfills these requirements
Change has impacts in these area(s)
Describe the reason for change
Users can be stuck after using Pan tool and unselecting it. Also that's inconsistent with Move tool.
Does this change affect performance?
nope
Does this change affect security?
nope
What alternative approaches were there?
Make Pan tool also not unselectable like Move tool. But for cases without drawing tools visible that would make it worse.
Does this PR introduce a breaking change?