Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OPTIC-1130: Unify and move Checkbox to Spark #6418

Merged
merged 40 commits into from
Oct 7, 2024
Merged

feat: OPTIC-1130: Unify and move Checkbox to Spark #6418

merged 40 commits into from
Oct 7, 2024

Commits on Sep 20, 2024

  1. feat: OPTIC-1130: Unify and move Checkbox to Spark

    @yyassi-heartex
    yyassi-heartex committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    207327d View commit details
    Browse the repository at this point in the history

  2. adding stale flag fflag_feat_optic_198_multi_select_users_short

    @yyassi-heartex
    yyassi-heartex committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e5fd035 View commit details
    Browse the repository at this point in the history

  3. add storybook support for all ui stories across the app, and add a st… 

    …ory for the refactored checkbox component
    @bmartel
    bmartel committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4bb3f21 View commit details
    Browse the repository at this point in the history

  4. formatting

    @bmartel
    bmartel committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f435abe View commit details
    Browse the repository at this point in the history

  5. Update README.md

    @bmartel
    bmartel authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cac70f7 View commit details
    Browse the repository at this point in the history

  6. Update README.md

    @bmartel
    bmartel authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8d09e4f View commit details
    Browse the repository at this point in the history

  7. Update preview.ts

    @bmartel
    bmartel authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2447e3f View commit details
    Browse the repository at this point in the history

  8. Update package.json

    @bmartel
    bmartel authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    51f9ff6 View commit details
    Browse the repository at this point in the history

  9. adding a more subtle focus effect to checkbox

    @yyassi-heartex
    yyassi-heartex committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a3ed126 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'fb-optic-1130/checkbox-component' of github.com:heartex… 

    …labs/label-studio into fb-optic-1130/checkbox-component
    @yyassi-heartex
    yyassi-heartex committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1f3629a View commit details
    Browse the repository at this point in the history

  11. Update web/package.json

    @bmartel
    bmartel authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f12f954 View commit details
    Browse the repository at this point in the history

  12. Update web/package.json

    @bmartel
    bmartel authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3271ce8 View commit details
    Browse the repository at this point in the history

  13. regenerate the yarn lock

    @bmartel
    bmartel committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2f81842 View commit details
    Browse the repository at this point in the history

  14. consolidate colors.scss to a single file

    @bmartel
    bmartel committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d3c75f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. lint clean up

    @yyassi-heartex
    yyassi-heartex committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4d5c7c9 View commit details
    Browse the repository at this point in the history

  2. update docs to include ui storybook runner at web dir README as well

    @bmartel
    bmartel committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e39f064 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'develop' into 'fb-optic-1130/checkbox-component' 

    Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11053608026
    @yyassi-heartex
    yyassi-heartex committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    422b6ba View commit details
    Browse the repository at this point in the history

  2. adding @humansignal/ui mapping for jest

    @yyassi-heartex
    yyassi-heartex committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8d2c4e5 View commit details
    Browse the repository at this point in the history

  3. tests are very invested in Choice using antd checkbox - needs to be c… 

    …leaned up thats more familiar with this usage
    @yyassi-heartex
    yyassi-heartex committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    63e6116 View commit details
    Browse the repository at this point in the history

  4. leave the proper package.json per lib since they are shared and we wa… 

    …nt to only consider these deps at the lib level
    @bmartel
    bmartel committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    368a1e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. remove test deps

    @bmartel
    bmartel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a9cd1a6 View commit details
    Browse the repository at this point in the history

  2. leave this out of the lib level

    @bmartel
    bmartel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0c1d25a View commit details
    Browse the repository at this point in the history

  3. updating checkbox to properly reference input via id

    @bmartel
    bmartel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    69c1ce1 View commit details
    Browse the repository at this point in the history

  4. do not need these files taking up space in repo

    @bmartel
    bmartel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    653d06f View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/develop' into fb-optic-1130/chec… 

    …kbox-component
    @bmartel
    bmartel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    55ef4bf View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Update web/libs/ui/src/lib/checkbox/checkbox.tsx 

    Co-authored-by: hlomzik <[email protected]>
    @bmartel @hlomzik
    bmartel and hlomzik authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    aec6ea4 View commit details
    Browse the repository at this point in the history

  2. Update web/libs/ui/src/lib/checkbox/checkbox.tsx 

    Co-authored-by: hlomzik <[email protected]>
    @bmartel @hlomzik
    bmartel and hlomzik authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e2c76ee View commit details
    Browse the repository at this point in the history

  3. Update web/libs/ui/src/lib/checkbox/checkbox.tsx

    @bmartel
    bmartel authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6ddeac6 View commit details
    Browse the repository at this point in the history

  4. Update web/libs/ui/src/tokens/colors.scss 

    Co-authored-by: hlomzik <[email protected]>
    @bmartel @hlomzik
    bmartel and hlomzik authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d00c4c0 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: hlomzik <[email protected]>
    @bmartel @hlomzik
    bmartel and hlomzik authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8b4eacf View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'develop' into fb-optic-1130/checkbox-component

    @yyassi-heartex
    yyassi-heartex committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9d35f1d View commit details
    Browse the repository at this point in the history

  2. fixing indeterminate + cleaning up multiple classname handling using … 

    …clsx library
    @yyassi-heartex
    yyassi-heartex committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3a6db1d View commit details
    Browse the repository at this point in the history

  3. lint cleanup

    @yyassi-heartex
    yyassi-heartex committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5590d02 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. significate visual overhaul for checkbox

    @yyassi-heartex
    yyassi-heartex committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1c66a67 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 'fb-optic-1130/checkbox-component' 

    Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11183065424
    @yyassi-heartex
    yyassi-heartex committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8f251b6 View commit details
    Browse the repository at this point in the history

  3. checkbox usage cleanup + react aliasing in LSO

    @yyassi-heartex
    yyassi-heartex committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a08681e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fb-optic-1130/checkbox-component' of github.com:heartex… 

    …labs/label-studio into fb-optic-1130/checkbox-component
    @yyassi-heartex
    yyassi-heartex committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cbf2d90 View commit details
    Browse the repository at this point in the history

  5. fixing grape_500-raw

    @yyassi-heartex
    yyassi-heartex committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2088471 View commit details
    Browse the repository at this point in the history

  6. lint cleanup

    @yyassi-heartex
    yyassi-heartex committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e9868e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'develop' into 'fb-optic-1130/checkbox-component' 

    Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11213348080
    @yyassi-heartex
    yyassi-heartex committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0dfa014 View commit details
    Browse the repository at this point in the history