Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPTIC-1130: Unify and move Checkbox to Spark #6418

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

starting to unify our components in to our ui library (Spark) - this reduces tech debt and allows us to work with the same component everywhere

This comment was marked as off-topic.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 55ef4bf
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66f6b3c3ae0ed20008955b3c

@github-actions github-actions bot added the feat label Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 55ef4bf
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66f6b3c3547b07000876c63b

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.65%. Comparing base (b1576ee) to head (55ef4bf).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6418   +/-   ##
========================================
  Coverage    76.65%   76.65%           
========================================
  Files          169      169           
  Lines        13749    13749           
========================================
  Hits         10539    10539           
  Misses        3210     3210           
Flag Coverage Δ
pytests 76.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

web/package.json Outdated Show resolved Hide resolved
web/package.json Outdated Show resolved Hide resolved
@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Sep 26, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/editor/src/stores/types.d.ts

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants