Port logging utils #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
commented
Oct 4, 2023
kemmerle
commented
Oct 4, 2023
kemmerle
commented
Oct 4, 2023
kemmerle
commented
Oct 4, 2023
kemmerle
commented
Oct 4, 2023
kemmerle
commented
Oct 4, 2023
camden11
reviewed
Oct 4, 2023
kemmerle
commented
Oct 5, 2023
kemmerle
commented
Oct 5, 2023
brandenrodgers
approved these changes
Oct 6, 2023
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
As part of our final push to port files from the
cli-libto thelocal-dev-liblibrary, I'm porting some logging utils that cannot be copied directly tohubspot-cli. This is because they're used in multiple packages:logs.ts: The one exported function in this file,
outputLogs, is called in both thecliandserverless-dev-runtimepackages inhubspot-cli.processFields.ts:processFieldsis only called inhandleFieldsJs.ts. handleFieldsJs is called in both theuploadFolder.tsandwatch.tsfiles, which are also used in the VSCode extension.checkAndWarnGitInclusion(ingit.ts): is called in both thecliandwebpack-cms-pluginspackages inhubspot-cli.Testing
I would really appreciate if someone would go through the
processFieldsJsfile in particular to see whether the changes I made from the original file incli-libmake sense. I've made notes on particularly tricky bits of code.TODO
Who to Notify
@camden11 @brandenrodgers