Remove logging "UI" utils from this library #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
We had a discussion about adding these logging utils a while ago here.
Now that we're starting to wire up the exports from this library into the CLI, I'm changing my mind about this pattern of including logging utils in here. The goal for this library is to enable us to separate the core business logic from the "UI" (aka CLI). Keeping UI related components in here will put us back into a spot where the dividing line between what goes in the CLI and what goes in this library will be blurry. One of the initial tenants for this lib was to make it as environment agnostic as possible, and keeping ui components in here doesn't really fit into that ideal.
I have a corresponding PR in the CLI where I port all of the deleted files from here back into the CLI. There's a tiny bit of duplicate code in some of the other packages, but IMO that's acceptable. I think eventually we should try to split out the webpack-cms-plugins and serverless-dev-runtime packages out into their own repos. They're a remnant from back when we treated the CLI repo as a monorepo, but we're moving away from that pattern. Duplicating the code in those packages will seem less gross if/when we move them out into their own repos.
Screenshots
TODO
Who to Notify