Adding logic for React modules in create command #44
Conversation
There was a problem hiding this comment.
Looks great, thanks for the Loom showcasing it!
I realize this isn't documented anywhere right now and our repos currently have a mixed state of react-modules and jsr-modules -- we want to move towards react-modules broadly as "JSR" is an internal acronym and we find that "react-modules" are more a bit more clear.
|
Has there been any discussion around supporting I don't think every developer uses Typescript for their JSR repos right now. For example the hello world repo is still predominantly written in JSX. |
Its a good question - I don't think there has been a ton of discussion around this -- With this particular request coming from the internal team. We should consider this. Maybe a follow up to this would be to add a question to the prompt if a React module is created to ask about it being TS or not. |
update to arrow function Co-authored-by: Jesse M <[email protected]>
…/cli-lib into ts/152-JSR-module-create
…moving the other smaller bits back in without function blocks
|
New issue created here for JSX module support: https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/498 |
| * @param {object} metaData - an object containing the module's metadata | ||
| */ | ||
|
|
||
| const transformFileContents = (file, metaData, getInternalVersion) => { |
There was a problem hiding this comment.
Is there an issue here where this function is doing async callbacky things bu there is no returned promise of async/await handling?
|
Closing out as the CLI was migrated to local-dev-lib and changes have been ported over there to mirror this PR |
Description and Context
With the advent of React modules being used in the CMS at HubSpot -- there is a need to include the ability to quickly scaffold a React module from the
hs create modulecommand.This PR adds logic so that a dev can call
hs create moduleand within the creation prompt, a new question has been added for creating a React type module. If this is selected, then the command will pull from the React sample asset in thecms-sample-assetsrepo.There is also some refining of the code after a React module has been downloaded to add the meta data information to the
index.tsxfile -- Additionally, if theinternalflag is passed, there are some regex replacements that happen to include some bits of code required by our internal team, as well as some additional files downloaded from the sample asset repo that pertain more to them.Screenshots
Loom of the command: https://www.loom.com/share/ea1e16ea73d946d685af94223a522bec?sid=8b5a1ee8-ceaf-49f6-b75f-1438c0e2d647
TODO