Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to create command to support React modules #976

Merged
merged 23 commits into from
Feb 21, 2024

Conversation

TanyaScales
Copy link
Member

@TanyaScales TanyaScales commented Jan 11, 2024

Description and Context

Pairs with HubSpot/hubspot-local-dev-lib#78 -- Adding more to the create prompt and passing some additional options through the create module command

Screenshots

See this cli-lib PR for Loom of the command

TODO

  • Update ATs

@TanyaScales TanyaScales requested review from jsines and j-malt January 12, 2024 16:01
Copy link
Contributor

@j-malt j-malt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 similar question as in cli-lib about adding support for regular JS modules, but code LGTM.

packages/cli/commands/create.js Outdated Show resolved Hide resolved
@TanyaScales TanyaScales merged commit e287deb into master Feb 21, 2024
1 check passed
@TanyaScales TanyaScales deleted the ts/152-JSR-module-create branch February 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants