Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imgur-album-downloader (new formula) #936

Closed
wants to merge 5 commits into from
Closed

imgur-album-downloader (new formula) #936

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ad7203
Added Imgur Album Downloader Formula
sgsunder May 7, 2016
de561ce
Update imgur-album-downloader.rb
sgsunder May 7, 2016
048d7d8
Update imgur-album-downloader.rb
sgsunder May 7, 2016
092d9b0
Update imgur-album-downloader.rb
sgsunder May 7, 2016
0ed1ce9
Switched to a more up-to-date fork
sgsunder Jul 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Formula/imgur-album-downloader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
class ImgurAlbumDownloader < Formula
desc "Command Line Utility to Download Imgur Albums"
homepage "https://github.com/sgsunder/imgur-album-downloader"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives a 404; should probably be https://github.com/alexgisby/imgur-album-downloader instead.

url "https://github.com/alexgisby/imgur-album-downloader.git", :revision => "dbaee1e342c1b46c022fccd26c294e251ac04015"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a tagged release here.

version "1"

bottle :unneeded

depends_on "python3"

def install
mv "imguralbum.py", "imgur-album-downloader" # Rename Command Line Script
bin.install "imgur-album-downloader"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use bin.install "imguralbum.py" => "imgur-album-downloader".

end

test do
system "#{bin}/imgur-album-downloader" # This should print the help message and return with exit code 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t we do something more substantial that just printing the help? E.g. download a small album?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if one of the preexisting test fixtures could be uploaded and then re-downloaded here

end
end