-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
micromamba: bump to 2.0.1 #195371
base: master
Are you sure you want to change the base?
micromamba: bump to 2.0.1 #195371
Conversation
Please provide a better issue/pull request title and/or description! |
I noticed that the homebrew-core/Formula/y/yaml-cpp.rb Lines 23 to 26 in 5406dc1
Digging more history about why it is build with shared option. Maybe no reason :) From the
so we may require to build and use the static one. |
We ship the shared libraries according to Homebrew policy: https://docs.brew.sh/Acceptable-Formulae#shared-vs-static-libraries Formulae should link to shared libraries. There are some intransigent build systems that refuse to do so, but we should fix those wherever we can. |
@@ -49,7 +50,6 @@ def install | |||
-DBUILD_LIBMAMBA=ON | |||
-DBUILD_SHARED=ON | |||
-DBUILD_MICROMAMBA=ON | |||
-DMICROMAMBA_LINKAGE=DYNAMIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just ship mamba
instead if that's the binary that supports shared linkage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the formula be named mamba then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we could do that. Though maybe we should just add a new mamba
formula and deprecate this one.
I'd have suggested a formula rename, but you've said that micromamba
and mamba
do not expose the same interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only interested in the new interface, the old "conda-compatible" one doesn't really have any reason to exist, IMO, now that conda has a (default) libmamba solver. But the micromamba interface is cleaner and using it is better in CI. I'll see if I can get any devs to comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I'm now wrong:
Mamba 2.0 Changes
Command Line ExecutablesMamba (executable)
mamba, previously a Python executable mixing libmambapy, conda, and code to bridge both project is being replace by a fully C++ executable based on libmamba solely.
It now presents the same user interface and experience as micromamba.
https://mamba.readthedocs.io/en/latest/developer_zone/changes-2.0.html
Okay, that's a breaking change, and so I think renaming to mamba and just providing mamba is likely the correct path forward.
In my defense, the docs still claim it has a different interface in several places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I just rename the formula in the PR? Or is there more to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's just the same now can't we just build mamba
and create a symlink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but should the formula still be renamed? Or an alias added (since both are shipped in one formula, that seems best?)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alias is probably simpler.
b7376c0
to
1dd060f
Compare
Signed-off-by: Henry Schreiner <[email protected]>
1dd060f
to
96c0bf7
Compare
96c0bf7
to
7fe14dc
Compare
Co-authored-by: Carlo Cabrera <[email protected]>
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This is a replacement for #191869 and #192460. This doesn't add a
mamba
symlink tomicromamba
, sincemicromamba
andmamba
do not have the same interface.