Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micromamba: bump to 2.0.1 #195371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 23, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is a replacement for #191869 and #192460. This doesn't add a mamba symlink to micromamba, since micromamba and mamba do not have the same interface.

Copy link

request-info bot commented Oct 23, 2024

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Oct 23, 2024
@daeho-ro
Copy link
Member

daeho-ro commented Oct 25, 2024

  CMake Error at cmake/Checks.cmake:9 (message):
    Expected type "STATIC_LIBRARY" for target "yaml-cpp::yaml-cpp" but found
    "SHARED_LIBRARY"

I noticed that the yaml-cpp is build with the shared option.

def install
system "cmake", ".", *std_cmake_args, "-DYAML_BUILD_SHARED_LIBS=ON",
"-DYAML_CPP_BUILD_TESTS=OFF"
system "make", "install"

Digging more history about why it is build with shared option.

lembacon@6199d97

Maybe no reason :)


From the yaml-cpp documentation,

yaml-cpp builds a static library by default, you may want to build a shared library by specifying -DYAML_BUILD_SHARED_LIBS=ON. ...

so we may require to build and use the static one.

@carlocab
Copy link
Member

We ship the shared libraries according to Homebrew policy: https://docs.brew.sh/Acceptable-Formulae#shared-vs-static-libraries

Formulae should link to shared libraries. There are some intransigent build systems that refuse to do so, but we should fix those wherever we can.

@@ -49,7 +50,6 @@ def install
-DBUILD_LIBMAMBA=ON
-DBUILD_SHARED=ON
-DBUILD_MICROMAMBA=ON
-DMICROMAMBA_LINKAGE=DYNAMIC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just ship mamba instead if that's the binary that supports shared linkage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the formula be named mamba then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we could do that. Though maybe we should just add a new mamba formula and deprecate this one.

I'd have suggested a formula rename, but you've said that micromamba and mamba do not expose the same interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only interested in the new interface, the old "conda-compatible" one doesn't really have any reason to exist, IMO, now that conda has a (default) libmamba solver. But the micromamba interface is cleaner and using it is better in CI. I'll see if I can get any devs to comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I'm now wrong:

Mamba 2.0 Changes
Command Line Executables

Mamba (executable)

mamba, previously a Python executable mixing libmambapy, conda, and code to bridge both project is being replace by a fully C++ executable based on libmamba solely.

It now presents the same user interface and experience as micromamba.

https://mamba.readthedocs.io/en/latest/developer_zone/changes-2.0.html

Okay, that's a breaking change, and so I think renaming to mamba and just providing mamba is likely the correct path forward.

In my defense, the docs still claim it has a different interface in several places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I just rename the formula in the PR? Or is there more to do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just the same now can't we just build mamba and create a symlink?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but should the formula still be renamed? Or an alias added (since both are shipped in one formula, that seems best?)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alias is probably simpler.

@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed needs response Needs a response from the issue/PR author labels Oct 25, 2024
Signed-off-by: Henry Schreiner <[email protected]>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 25, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 25, 2024
Co-authored-by: Carlo Cabrera <[email protected]>
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants