Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve locking UX #17904

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Improve locking UX #17904

merged 1 commit into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. Improve locking UX

    My experience recently playing around with our locking behaviour is
    that, while mostly seamless and not seen by users, it's leaks
    implementation details a bit too heavily.
    
    As a result, the following improvements are in this commit:
    - Ensure that, whenever possible, we tell the user the actual command
      that is holding a given lock instead of the lock name (an internal
      implementation detail)
    - Make the locking error output a little more consistent and user
      friendly
    - Add a `DownloadLock` class to simplify locking downloads
    - Add a `HOMEBREW_LOCK_CONTEXT` variable to allow adding additional
      context for logging error messages
    - Lock paths and leave deciding how this translates to lock names up
      to the locking code itself
    - Lock the Cellar/Caskroom paths explicitly rather than implicitly
    
    Co-authored-by: Carlo Cabrera <[email protected]>
    MikeMcQuaid and carlocab committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e3a1a9d View commit details
    Browse the repository at this point in the history