Improve locking UX #17904
Merged
Improve locking UX #17904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
lock_improvements
branch
from
090ca84
to
91c8ab2
Compare
Bo98
approved these changes
Jul 30, 2024
carlocab
approved these changes
Jul 30, 2024
MikeMcQuaid
force-pushed
the
lock_improvements
branch
2 times, most recently
from
5c0420b
to
99c9899
Compare
MikeMcQuaid
force-pushed
the
lock_improvements
branch
from
99c9899
to
d337171
Compare
My experience recently playing around with our locking behaviour is that, while mostly seamless and not seen by users, it's leaks implementation details a bit too heavily. As a result, the following improvements are in this commit: - Ensure that, whenever possible, we tell the user the actual command that is holding a given lock instead of the lock name (an internal implementation detail) - Make the locking error output a little more consistent and user friendly - Add a `DownloadLock` class to simplify locking downloads - Add a `HOMEBREW_LOCK_CONTEXT` variable to allow adding additional context for logging error messages - Lock paths and leave deciding how this translates to lock names up to the locking code itself - Lock the Cellar/Caskroom paths explicitly rather than implicitly Co-authored-by: Carlo Cabrera <[email protected]>
MikeMcQuaid
force-pushed
the
lock_improvements
branch
from
d337171
to
e3a1a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My experience recently playing around with our locking behaviour is that, while mostly seamless and not seen by users, it's leaks implementation details a bit too heavily.
As a result, the following improvements are in this PR:
DownloadLockclass to simplify locking downloadsHOMEBREW_LOCK_CONTEXTvariable to allow adding additional context for logging error messages