Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_creator: Remove path attr to reduce code complexity #16244

Merged
merged 5 commits into from
Nov 23, 2023
Merged

formula_creator: Remove path attr to reduce code complexity #16244

merged 5 commits into from
Nov 23, 2023

Commits on Nov 21, 2023

  1. formula_creator: Remove path attr to reduce code complexity 

    `path` attribute is used only once, and it is easier to calculate
it on the fly than to update its state after different methods.
    @abitrolly
    abitrolly committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    51b1658 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Rename generate! to write_formula!

    @abitrolly
    abitrolly committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d8f19ff View commit details
    Browse the repository at this point in the history

  2. Raise when formula name is empty 

    P.S. That still doesn't check if the name is invalid, like "34"
    @abitrolly
    abitrolly committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4fed452 View commit details
    Browse the repository at this point in the history

  3. Style fix

    @abitrolly
    abitrolly committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    bfbea8b View commit details
    Browse the repository at this point in the history

  4. Suggestion by @MikeMcQuaid 

    "ActiveSupport adds blank? to NilClass."
    @abitrolly
    abitrolly committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4063675 View commit details
    Browse the repository at this point in the history