Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help center feature split #2069

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Help center feature split #2069

wants to merge 7 commits into from

Commits on Apr 5, 2024

  1. Split feature-help-center into a -ui and a -data module 

    This should allow us to keep the Android only dependencies in the -ui
module and in the future allow us to keep the -data one clean of any non
KMP compatible dependencies

This does no changes to the functionality/logic of that feature, only
moves things around
    @StylianosGakis
    StylianosGakis committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4d56304 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/feature/new-cancellation-flow' into feature/… 

    …help-center-feature-split

# Conflicts:
#	app/feature/feature-help-center/feature-help-center-ui/build.gradle.kts
    @StylianosGakis
    StylianosGakis committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7cd4c15 View commit details
    Browse the repository at this point in the history

  3. Move dataTermination to the data module

    @StylianosGakis
    StylianosGakis committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c80f1ce View commit details
    Browse the repository at this point in the history

  4. Add androidx.annotation for the StringRes annotation

    @StylianosGakis
    StylianosGakis committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    81a6856 View commit details
    Browse the repository at this point in the history

  5. Make the data module expose a simple HelpCenterContext 

    Avoids having to know anything about the context in the destination
object itself
    @StylianosGakis
    StylianosGakis committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    fc203c9 View commit details
    Browse the repository at this point in the history

  6. Turn HelpCenterContext to the destination context before passing it

    @StylianosGakis
    StylianosGakis committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    36fc8d4 View commit details
    Browse the repository at this point in the history

  7. Update module graph

    @StylianosGakis
    StylianosGakis committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    9647a0c View commit details
    Browse the repository at this point in the history