Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help center feature split #2069

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

StylianosGakis
Copy link
Member

split into "...-ui" module, to stay as the android module
And into "...-data" module which we can look into moving into a jvm module as a first step.
More modules need to be migrated first for this to be possible, like the gql one, but this is just a step in this process :D

This was branched from develop and I merged help-center-feature into it, which is why it contains more commits as well as what I did here. This will be cleared up when we just merge that feature to develop anyway, or when we just bring develop into it instead. For now don't bother reviewing yet.

This should allow us to keep the Android only dependencies in the -ui
module and in the future allow us to keep the -data one clean of any non
KMP compatible dependencies

This does no changes to the functionality/logic of that feature, only
moves things around
…help-center-feature-split

# Conflicts:
#	app/feature/feature-help-center/feature-help-center-ui/build.gradle.kts
Avoids having to know anything about the context in the destination
object itself
Base automatically changed from feature/new-cancellation-flow to develop April 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant