-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: local office/DBC TSS requests #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain about the best way to address the code smell. Making greater use of the switch statement might not be enough without delegating the additional check to another method for each use.
|
Tbh, I thought it was a bit of a false-positive, given the offending function is very simple to understand and hardly 'complex', even if it is a bit ugly. 🤷 I have made a limited refactor, without burying the logic in a whole lot of configuration, but if you prefer a different approach I'll do that. |
Dependent on Health-Education-England/TIS-REFERENCE#343. Allow local office and DBC requests by abbreviation.
TIS21-6279