Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: local office/DBC TSS requests #253

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Conversation

ReubenRobertsHEE
Copy link
Contributor

@ReubenRobertsHEE ReubenRobertsHEE commented Jul 17, 2024

Dependent on Health-Education-England/TIS-REFERENCE#343. Allow local office and DBC requests by abbreviation.

TIS21-6279

@ReubenRobertsHEE ReubenRobertsHEE changed the title feat: local office TSS requests feat: local office/DBC TSS requests Jul 17, 2024
ReubenRobertsHEE added a commit to Health-Education-England/tis-trainee-sync that referenced this pull request Jul 17, 2024
@ReubenRobertsHEE ReubenRobertsHEE marked this pull request as ready for review July 18, 2024 10:51
@ReubenRobertsHEE ReubenRobertsHEE requested review from a team, JosephKelly, CaiWillis and hihilary and removed request for a team July 18, 2024 10:51
Copy link
Contributor

@JosephKelly JosephKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain about the best way to address the code smell. Making greater use of the switch statement might not be enough without delegating the additional check to another method for each use.

Copy link

@ReubenRobertsHEE
Copy link
Contributor Author

I'm not certain about the best way to address the code smell. Making greater use of the switch statement might not be enough without delegating the additional check to another method for each use.

Tbh, I thought it was a bit of a false-positive, given the offending function is very simple to understand and hardly 'complex', even if it is a bit ugly. 🤷 I have made a limited refactor, without burying the logic in a whole lot of configuration, but if you prefer a different approach I'll do that.

@JosephKelly JosephKelly merged commit b49cdba into main Jul 19, 2024
2 checks passed
@JosephKelly JosephKelly deleted the feat/localOfficeTssRequests branch July 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants