Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DBC / LocalOffice Programme owner refactor #469

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

ReubenRobertsHEE
Copy link
Contributor

@ReubenRobertsHEE ReubenRobertsHEE commented Jul 17, 2024

For context see (now removed) comment:

    //NOTE: refactor this as per: https://hee-tis.atlassian.net/browse/TIS21-6228
    //As a Designated body name will no longer be equal to a Local Office name, and the programme
    //owner is a Local Office name, the 'findByOwner()' below will become invalid.
    //This may require
    // (1) sync LocalOffice into sync db as well as reference.
    // (2) ensure abbr field is included (its missing from the Reference LocalOffice collection)
    // (3) join dbc.abbr <-> LocalOffice.abbreviation and use LocalOffice.name <-> Programme.owner

Dependent on
Health-Education-England/TIS-REFERENCE#343 and Health-Education-England/TIS-SYNC#253

TIS21-6273

Copy link

@ReubenRobertsHEE ReubenRobertsHEE requested a review from a team July 17, 2024 15:12
@ReubenRobertsHEE ReubenRobertsHEE marked this pull request as ready for review July 17, 2024 15:13
* @param value The field value of the Dbc to be retrieved.
*/
private void request(String key, String value) {
if (!requestCacheService.isItemInCache(Dbc.ENTITY_NAME, value)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'value' can be either a dbc or an abbr. These should never overlap (share the same value), so there should never be key collisions - but if desired we could either prefix them with the type of key (to ensure uniqueness) or have two separate caches.

Copy link
Contributor

@DorisWongNHS DorisWongNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReubenRobertsHEE ReubenRobertsHEE merged commit ed253ab into main Jul 19, 2024
3 checks passed
@ReubenRobertsHEE ReubenRobertsHEE deleted the feat/dbcLocalOfficeProgrammeOwnerRefactor branch July 19, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants