-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync for postfunding status #243
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be able to disregard the messages with 😕 emojis. They are only relevant if we expect there to be some places where this is null.
src/main/java/uk/nhs/tis/sync/event/listener/JobRunningListener.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/tis/sync/event/listener/JobRunningListener.java
Outdated
Show resolved
Hide resolved
f0c294f
to
a7cd956
Compare
ef98cc9
to
c560122
Compare
c560122
to
b6d9bcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B. I don't think this covers all acceptance criteria, specifically the ones about funding start dates.
The job still includes the date variable and code to vary based on that but no user/operator can make use of that flexibility.
src/main/java/uk/nhs/tis/sync/job/PersonDateChangeCaptureSyncJobTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/tis/sync/job/PostFundingSyncJobTemplate.java
Outdated
Show resolved
Hide resolved
3951fe5
to
7957524
Compare
86e5c79
to
7243f92
Compare
7243f92
to
fc67e0c
Compare
Quality Gate failedFailed conditions |
* Job for updating funding status for posts. This class extends the | ||
* PersonDateChangeCaptureSyncJobTemplate and provides functionality to synchronize post funding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B. Adding a reminder comment to check that the comment is updated to match the class relationship.
No description provided.