Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync for postfunding status #243

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Conversation

jayanta2018
Copy link
Contributor

No description provided.

@jayanta2018 jayanta2018 requested a review from JosephKelly April 24, 2024 11:31
Copy link
Contributor

@JosephKelly JosephKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be able to disregard the messages with 😕 emojis. They are only relevant if we expect there to be some places where this is null.

src/main/java/uk/nhs/tis/sync/api/JobResource.java Outdated Show resolved Hide resolved
src/main/java/uk/nhs/tis/sync/api/JobResource.java Outdated Show resolved Hide resolved
src/main/java/uk/nhs/tis/sync/job/PostFundingSyncJob.java Outdated Show resolved Hide resolved
src/main/java/uk/nhs/tis/sync/api/JobResource.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/main/resources/config/application.yml Show resolved Hide resolved
src/main/java/uk/nhs/tis/sync/job/PostFundingSyncJob.java Outdated Show resolved Hide resolved
@jayanta2018 jayanta2018 force-pushed the sync-for-postfunding-status branch 3 times, most recently from f0c294f to a7cd956 Compare May 3, 2024 10:24
@jayanta2018 jayanta2018 force-pushed the sync-for-postfunding-status branch 3 times, most recently from ef98cc9 to c560122 Compare May 8, 2024 13:02
@jayanta2018 jayanta2018 force-pushed the sync-for-postfunding-status branch from c560122 to b6d9bcb Compare May 8, 2024 13:09
Copy link
Contributor

@JosephKelly JosephKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. I don't think this covers all acceptance criteria, specifically the ones about funding start dates.

The job still includes the date variable and code to vary based on that but no user/operator can make use of that flexibility.

@jayanta2018 jayanta2018 force-pushed the sync-for-postfunding-status branch from 3951fe5 to 7957524 Compare May 10, 2024 10:42
@jayanta2018 jayanta2018 force-pushed the sync-for-postfunding-status branch from 86e5c79 to 7243f92 Compare May 14, 2024 13:05
@jayanta2018 jayanta2018 force-pushed the sync-for-postfunding-status branch from 7243f92 to fc67e0c Compare May 14, 2024 20:59
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jayanta2018 jayanta2018 requested a review from JosephKelly May 15, 2024 08:26
Comment on lines +36 to +37
* Job for updating funding status for posts. This class extends the
* PersonDateChangeCaptureSyncJobTemplate and provides functionality to synchronize post funding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. Adding a reminder comment to check that the comment is updated to match the class relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants