fix: handle pull request comments

Health-Education-England · May 10, 2024 · 3951fe5 · 3951fe5
1 parent b6d9bcb
commit 3951fe5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/uk/nhs/tis/sync/job/PersonDateChangeCaptureSyncJobTemplate.java b/src/main/java/uk/nhs/tis/sync/job/PersonDateChangeCaptureSyncJobTemplate.java
@@ -90,7 +90,7 @@ protected void runSyncJob(String dateOption) {
         });
   }
 
-  protected void doDataSync(String dateOption) {
+  private void doDataSync(String dateOption) {
     // Configure run
     LocalDate dateOfChange = magicallyGetDateOfChanges(dateOption);
     String queryString = buildQueryForDate(dateOfChange);

diff --git a/src/test/java/uk/nhs/tis/sync/job/PostFundingSyncJobTest.java b/src/test/java/uk/nhs/tis/sync/job/PostFundingSyncJobTest.java
@@ -15,6 +15,7 @@
 import java.time.format.DateTimeFormatter;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
@@ -98,10 +99,10 @@ void testJobShouldChangeCurrentPostFundingToInactive() {
     PostFunding postFunding = new PostFunding();
     postFunding.setId(999L);
     post.fundingStatus(Status.CURRENT);
-    Set<PostFunding> postFundingSet = new HashSet<>(Arrays.asList(postFunding));
+    Set<PostFunding> postFundingSet = Collections.singleton(postFunding);
     post.setFundings(postFundingSet);
 
-    when(entityManager.find(eq(Post.class), anyLong())).thenReturn(post);
+    when(entityManager.find(eq(Post.class), eq(post.getId()))).thenReturn(post);
 
     List<Long> entityData = Arrays.asList(1L);