Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing rendezvous restriction for matching local and remote ports #1204

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Removing rendezvous restriction for matching local and remote ports #1204

merged 2 commits into from
Apr 1, 2020

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Mar 25, 2020 •
edited
Loading

Changes

  • Small improvements of srt-live-transmit doc regarding rendezvous mode parameters.
  • srt_rendezvous(..) in API.md has the following note: "The port value shall be the same in local_name and remote_name." Deleted.
  • srt_rendezvous(..) function has a port check: remote should match to local. Removed.

TODO

  • Check firewall traversal in case of different local and remote ports

TODO in case of the restriction is valid

  • Fix API-functions.md: return value INVAL is missing
  • Check why srt-live-transmit allows to configure a different rendezvous port
    "srt://192.168.178.182:4200?adapter=192.168.1.237&port=4201"

See Also

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Mar 25, 2020
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone Mar 25, 2020
@maxsharabayko maxsharabayko mentioned this pull request Mar 25, 2020
Merged
@maxsharabayko maxsharabayko merged commit 9f7d93b into Haivision:master Apr 1, 2020
@maxsharabayko maxsharabayko deleted the hotfix/rendezvous-ports branch April 1, 2020 07:10
@maxsharabayko maxsharabayko linked an issue Apr 16, 2020 that may be closed by this pull request
[feature] Specify different remote and local ports for rendezvous connections in stransmit #526
Closed
@maxsharabayko maxsharabayko mentioned this pull request Apr 16, 2020
Closed
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

[feature] Specify different remote and local ports for rendezvous connections in stransmit
3 participants
@maxsharabayko @ethouris @mbakholdina