Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Specify different remote and local ports for rendezvous connections in stransmit #526

Closed
russelltg opened this issue Dec 28, 2018 · 4 comments · Fixed by #1204
Closed
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Milestone

Comments

@russelltg
Copy link
Contributor

russelltg commented Dec 28, 2018

Related: #369

It seems useful to be able to specify different port numbers for the local and remote while negotiating rendezvous connections.

For example, the public port (on the router) may not match the port on the machine (is is already mapped to a different local ip, etc), so it would be difficult to configure.

Additionally, it allows for local testing of rendezvous connections (my personal interest).

If there is interest in such a feature, I am willing to implement it.

One possible syntax could be stransmit srt://hello.com:3333?mode=rendezvous?local_port=4444 ..., where this would bind to port 4444 but connect to port 3333.

This syntax could also be added for callers.

@ethouris
Copy link
Collaborator

ethouris commented Jan 7, 2019

I haven't tracked down exactly this requirement that the port number should be the same on both sides for rendezvous. For what I know about the rendezvous process, there should be no real obstacle to use different ports per site in rendezvous. The parameter you designated as local_port already exists and it's simply port, although the only current use of it is in caller mode to specify the local outgoing port, but it does what you want: sets the port to which the local UDP socket is bound.

But to be sure that this can be used safely, I need to make more investigation.

@ethouris ethouris added the Type: Enhancement Indicates new feature requests label Jan 7, 2019
@ethouris ethouris added this to the v1.4.1 milestone Aug 13, 2019
@ethouris ethouris added the [core] Area: Changes in SRT library core label Aug 13, 2019
@maxsharabayko maxsharabayko modified the milestones: v1.4.1, v1.4.2 Nov 4, 2019
@maxsharabayko maxsharabayko modified the milestones: v1.5.0, v1.6.0 Dec 27, 2019
@maxsharabayko
Copy link
Collaborator

maxsharabayko commented Apr 16, 2020

It looks like this was resolved in #1204, which removed extra checks for local and remote ports in rendezvous to be the same.
Now the following syntax can be used:
srt-live-transmit srt://hello.com:3333?mode=rendezvous?port=4444, where this would bind to port 4444 but connect to port 3333.

@maxsharabayko maxsharabayko modified the milestones: v1.6.0, v1.5.0 Apr 16, 2020
@maxsharabayko
Copy link
Collaborator

maxsharabayko commented Apr 16, 2020

Waiting for #1198 which fixes rendezvous handling in URI parsing.

@maxsharabayko
Copy link
Collaborator

#1198 is merged. Closing this request.
@russelltg Please don't hesitate to reopen in case something was missed.

@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants