Fix enum plot crashes #1673
Merged
Fix enum plot crashes #1673
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidma
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
On main twix crashes reliably when an enum plot panel is open, twix is set to automatically connect to localhost and a replayer is started.
The root cause is that the subscription goes through before the replayer replays the first frame, causing the response to the subscription request to contain data from the Default element of the
buffered_watchchannel, which is a default database timestamped atSystemTime::UNIX_EPOCH.Since the enum plot panel has to calculate the range for its X-axis, mixing unix epoch timestamps with about now timestamps breaks the f32 resolution used for the range calculation.
A proper fix would require rethinking what data should be transmitted by the communication server, which probably would result in some major changes in communication. This PR is just a hotfix to filter the bad updates on the client side.
Fixes #
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test